Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314169 - ti.targets.ITarget.xs needs --embed_inline_assembly for all 6x (not just 66)
Summary: ti.targets.ITarget.xs needs --embed_inline_assembly for all 6x (not just 66)
Status: CLOSED FIXED
Alias: None
Product: RTSC
Classification: Technology
Component: Targets (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sasha Slijepcevic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 17:07 EDT by Karl Wechsler CLA
Modified: 2011-11-09 18:55 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Wechsler CLA 2010-05-24 17:07:59 EDT 
This code:

            /* For MSP430 3.3 and newer compilers and C6x 7.1 and newer
             * compilers, we are adding '--embed_inline_assembly' to enable
             * the config C file to participate in whole_program optimization
             */
            if (goal.configOpts) {
                var compString = target.getVersion().split('{')[1];
                var compVersion = compString.split(',');
                if ((target.isa == "66" && compVersion[2] >= "7.1")
                    || (target.isa.substring(0, 3) == "430")) {
                        ccoptsSuf += " --embed_inline_assembly";
                    }
            }


Needs to be updated for _all_ 6x!


I tried using 7.2.0A tools for 64P and I am getting error about embedded inline assembly.  7.2.x will be used for _all_ 6x someday soon.  We need this option for all 6x.
Comment 1 Sasha Slijepcevic CLA 2010-05-25 18:39:44 EDT 
This was fixed in xdctargets-c23 (XDCtools 3.20.00.39). For some targets (C64, elf.C64T and possibly others) in 7.1 compilers, the option in question is not available and will result in a warning.

# cl64 package/cfg/client_x64.c ...
/db/toolsrc/library/tools/vendors/ti/c6x/7.1.0B0/Linux/bin/cl6x -c -oe -mo -mv6400 -eo.o64 -ea.s64 --embed_inline_assembly  -Dxdc_cfg__header__='idioms/i304/package/cfg/client_x64.h'  -Dxdc_target_name__=C64 -Dxdc_target_types__=ti/targets/std.h -Dxdc_bld__profile_whole_program -Dxdc_bld__vers_1_0_7_1_0_1 -oe -O2 -mo -I. -I/db/rtree/sasa/xdcprod-m36/product/Linux/xdctools_3_20_00_36_eng/packages -I../.. -I/db/toolsrc/library/tools/vendors/ti/c6x/7.1.0B0/Linux/include -fs=./package/cfg -fr=./package/cfg -fc package/cfg/client_x64.c
>> WARNING: invalid compiler option --embed_inline_assembly (ignored)
Comment 2 Dave Russo CLA 2011-11-09 18:55:52 EST 
closing "ancient" resolved bugs