Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314129 - [publisher] EquinoxLauncherCUAction does not generate the ini file when called from the ProductPublisherApplication
Summary: [publisher] EquinoxLauncherCUAction does not generate the ini file when calle...
Status: RESOLVED DUPLICATE of bug 377628
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: Juno M7   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331974
  Show dependency tree
 
Reported: 2010-05-24 11:42 EDT by Hugues Malphettes CLA
Modified: 2012-04-28 13:36 EDT (History)
5 users (show)

See Also:

Attachments
query the metadata repo when no advice is found. (4.75 KB, patch)
2010-05-24 11:42 EDT, Hugues Malphettes CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugues Malphettes CLA 2010-05-24 11:42:23 EDT 
Created attachment 169683 [details]
query the metadata repo when no advice is found.

When ProductPublisherApplication is invoked the EquinoxLauncherCUAction is performed. However EquinoxLauncherCUAction#publishCU looks for the equinox launcher using:
Collection<IVersionAdvice> advice = info.getAdvice(configSpec, true, id, null, IVersionAdvice.class);

And this collection is empty.
I suspect this works when that action is invoked by the EclipseGenerator because it has just collected all the artifacts.

The patch consists of querying the metadata repository for the launcher if we find no advice for it.
I kept the old code although it seems to me we might as well always query the metadata repository.
Comment 1 Pascal Rapicault CLA 2011-05-02 14:26:08 EDT 
See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=314002
Comment 2 Ian Bull CLA 2011-05-29 23:48:25 EDT 
It's not clear if this is still a problem with all the publisher work that was done recently. I will look at this for 3.7.1
Comment 3 Hugues Malphettes CLA 2011-05-29 23:54:25 EDT 
Hi Ian, this issue was filed back in May 2010; before all the work that took place in the incubator.
Comment 4 Ian Bull CLA 2011-05-29 23:59:32 EDT 
(In reply to comment #3)
> Hi Ian, this issue was filed back in May 2010; before all the work that took
> place in the incubator.

Yes, do you know if this is still a problem, or was this addressed as part of tha work? (I don't have the code in front of me right now).
Comment 5 Hugues Malphettes CLA 2011-05-30 02:42:44 EDT 
I have not followed exactly what was affected and I have not checked the code yet either :/
Comment 6 Thomas Watson CLA 2011-08-31 10:29:55 EDT 
Investigate in 3.7.2.
Comment 7 Ian Bull CLA 2012-01-23 13:08:54 EST 
Moving to Juno for investigation.
Comment 8 Ian Bull CLA 2012-04-27 17:36:22 EDT 
Moving off the plan since we don't really know if this is still needed.
Comment 9 Pascal Rapicault CLA 2012-04-28 13:36:44 EDT 
This got fixed earlier this week.

*** This bug has been marked as a duplicate of bug 377628 ***