Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314091 - IModelExtensions should be created through DI
Summary: IModelExtensions should be created through DI
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Project Inbox CLA
QA Contact: Oleg Besedin CLA
URL:
Whiteboard:
Keywords:
Depends on: 309867
Blocks:
  Show dependency tree
 
Reported: 2010-05-24 06:13 EDT by Thomas Schindl CLA
Modified: 2012-05-11 07:22 EDT (History)
2 users (show)

See Also:


Attachments
Patch - just in case it needs to be reversed (1.51 KB, patch)
2010-06-25 10:12 EDT, Oleg Besedin CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-05-24 06:13:43 EDT
This would allow them to directly reference e.g. OSGi-Services, ... .
Comment 1 Paul Webster CLA 2010-05-28 08:35:05 EDT
My browser accidentally removed this.
PW
Comment 2 Oleg Besedin CLA 2010-06-24 15:30:11 EDT
Is this still valid? IModelExtension does not seem to be used anywhere anymore and model processors are called like this:

  ContextInjectionFactory.invoke(o, Execute.class, localContext);

(ModelAssembler#runProcessor()).
Comment 3 Thomas Schindl CLA 2010-06-25 04:17:55 EDT
You are right - We should remove the interface because it is not of any use
Comment 4 Oleg Besedin CLA 2010-06-25 10:12:08 EDT
Created attachment 172757 [details]
Patch - just in case it needs to be reversed
Comment 5 Oleg Besedin CLA 2010-06-25 10:12:43 EDT
Done.