Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314087 - Optimize and simplify SelectSet
Summary: Optimize and simplify SelectSet
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 7.1.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 7.0.2.RC0   Edit
Assignee: Simone Bordet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 05:53 EDT by Greg Wilkins CLA
Modified: 2011-09-20 15:51 EDT (History)
2 users (show)

See Also:

Attachments
work in progresss (27.82 KB, patch)
2010-05-24 05:59 EDT, Greg Wilkins CLA 		no flags Details | Diff
work in progress II (40.38 KB, patch)
2010-07-12 11:23 EDT, Greg Wilkins CLA 		no flags Details | Diff
simplification of select set handling (41.69 KB, patch)
2010-07-15 09:14 EDT, Greg Wilkins CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Wilkins CLA 2010-05-24 05:53:12 EDT 
The select manager has a lot of legacy code in it from various different ways of operating.  This should be simplified, rationalized and optimized for a the latest understanding of how NIO works.
Comment 1 Greg Wilkins CLA 2010-05-24 05:59:48 EDT 
Created attachment 169654 [details]
work in progresss

simplified changes.
blocking connects and accepts
select now tried before blocking send
Comment 2 Greg Wilkins CLA 2010-07-12 11:23:16 EDT 
Created attachment 174045 [details]
work in progress II

still more work to do
Comment 3 Greg Wilkins CLA 2010-07-15 09:14:01 EDT 
Created attachment 174395 [details]
simplification of select set handling

This patch is significantly simpler and passes all the unit tests
Comment 4 Greg Wilkins CLA 2010-07-15 09:15:45 EDT 
Simone,

can you look at this latest patch.  It simplifies the handling of select set, without being too radical.

Are there any other improvements that you think we can make without complete revolution?

cheers
Comment 5 Simone Bordet CLA 2011-03-29 05:00:39 EDT 
SelectSet has been simplified by factoring the checks for JVM bugs.
However, the patch was also removing the asynchronous connects, which turned out to be an important use case.
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=337678 for further details.
Resolving as fixed by Greg's work.
Comment 6 Jesse McConnell CLA 2011-09-20 15:51:44 EDT 
Resolved -> Closed