Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314057 - Enable subclass of Table Data Editor to provide result column ordering
Summary: Enable subclass of Table Data Editor to provide result column ordering
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Table Data Editor (show other bugs)
Version: 1.8   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.8   Edit
Assignee: Brian Payton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 00:46 EDT by Brian Payton CLA
Modified: 2010-05-25 03:25 EDT (History)
0 users

See Also:


Attachments
Patch for plugins o.e.d.sqltools.data.core and o.e.d.sqltools.data.ui (24.91 KB, patch)
2010-05-24 00:54 EDT, Brian Payton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Payton CLA 2010-05-24 00:46:40 EDT
The Table Data Editor UI classes currently assume that the edit columns and rows map to SELECT * FROM <tablename>.  The UI has code like this:
  editor.getTable().getColumns() 
That is, the UI classes work with the columns of the source table of the query defining the edit, rather than the result columns of the query defining the edit.  The Table Data Editor core actually maintains a field for the result columns, "resultColumns", so that assumption is not needed.  However, this field is not exposed in the API.

The result columns field needs to be exposed in the TableData2 interface, and the Table Data Editor UI classes need to use it when accessing the edit columns rather than getting the edit columns directly from the source table.
Comment 1 Brian Payton CLA 2010-05-24 00:54:51 EDT
Created attachment 169626 [details]
Patch for plugins o.e.d.sqltools.data.core and o.e.d.sqltools.data.ui
Comment 2 Brian Payton CLA 2010-05-25 03:25:34 EDT
Checked in change, tagged to v201005241300.