Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314039 - [dom] [rewrite] more complete rewriting for method mappings
Summary: [dom] [rewrite] more complete rewriting for method mappings
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.7   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 0.7 M3   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 310923
  Show dependency tree
 
Reported: 2010-05-23 05:25 EDT by Stephan Herrmann CLA
Modified: 2010-05-29 17:28 EDT (History)
0 users

See Also:

Attachments
tests & fix (31.47 KB, patch)
2010-05-24 08:14 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2010-05-23 05:25:46 EDT 
Currently, DOM rewriting cannot handle some changes of method mappings,
notably adding/removing signatures.
Comment 1 Stephan Herrmann CLA 2010-05-24 08:14:46 EDT 
Created attachment 169668 [details]
tests & fix

Implementation:
- ASTRewriteAnalyzer: implement rewriting incl. adding/removing signatures
- Parser: ensure methodSpec.declarationSourceStart does include a type parameter
- new helper AbstractMethodMappingDeclaration.removeSignatures()
- fix MethodSpec/FieldAccessSpec: 
  {field,return}Type is optional, don't init with "void"
Comment 2 Stephan Herrmann CLA 2010-05-24 08:17:04 EDT 
Patch has been committed as r369.
Comment 3 Stephan Herrmann CLA 2010-05-29 17:28:17 EDT 
verified for M3 using 201005282024 
(indirectly via bug 310923 and by way of tests).