Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314002 - [publisher] EclipseLauncherParser#read does not compute correction osgiInstallArea with macosx
Summary: [publisher] EclipseLauncherParser#read does not compute correction osgiInstal...
Status: RESOLVED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: Macintosh All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 331974
  Show dependency tree
 
Reported: 2010-05-21 21:39 EDT by Hugues Malphettes CLA
Modified: 2019-10-08 10:50 EDT (History)
5 users (show)

See Also:


Attachments
patch to use ParserUtils to locate the osgiinstall area (2.21 KB, patch)
2010-05-22 14:07 EDT, Hugues Malphettes CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hugues Malphettes CLA 2010-05-21 21:39:19 EDT
When executing the PublishProduct application under linux against a macosx build, the EquinoxManipulatorImpl.checkConsistencyOfFwConfigLocAndFwPersistentDataLoc fails.

The issue lies in org.eclipse.equinox.internal.frameworkadmin.equinox.EclipseLauncherParser#read

line 61 to 64 reads:
URI osgiInstallArea = getOSGiInstallArea(lines, launcherFolder);
if (osgiInstallArea == null) {
	osgiInstallArea = launcherData.getFwJar() != null ? ParserUtils.fromOSGiJarToOSGiInstallArea(launcherData.getFwJar().getAbsolutePath()).toURI() : launcherFolder;
}

This code assumes that the executable is located at the root of the eclipse installation. That is not the case for a macosx product.

EclipseLauncherParser should always call ParserUtils#getOSGiInstallArea where the macosx case is supported (https://bugs.eclipse.org/bugs/show_bug.cgi?id=280007#c19)

The fix consist of replacing line 61 to 64 by
URI osgiInstallArea = ParserUtils.getOSGiInstallArea(lines, null, launcherData).toURI();


Workaround: if the launcher.ini file contains the -startup parameter then we are OK.
Comment 1 Hugues Malphettes CLA 2010-05-22 14:07:01 EDT
Created attachment 169588 [details]
patch to use ParserUtils to locate the osgiinstall area
Comment 2 Hugues Malphettes CLA 2010-05-24 11:46:43 EDT
This bug would appear if the launcher's ini file was properly generated.
However that is not the case when the ProductPublisher is used: https://bugs.eclipse.org/bugs/show_bug.cgi?id=314129
Comment 3 Ian Bull CLA 2011-05-29 23:48:47 EDT
It's not clear if this is still a problem with all the publisher work that was done recently. I will look at this for 3.7.1
Comment 4 Thomas Watson CLA 2011-08-31 10:29:09 EDT
Moving to investigate in 3.7.2
Comment 5 Ian Bull CLA 2012-01-23 13:05:37 EST
Moving out.
Comment 6 Pascal Rapicault CLA 2014-05-05 10:23:41 EDT
Unsetting old milestones
Comment 7 Eclipse Genie CLA 2019-03-29 16:56:04 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Lars Vogel CLA 2019-10-08 10:50:13 EDT
This bug was marked as stalebug a while ago. Marking as wontfix.

If this report is still relevant for the current release, please
reopen and remove the stalebug whiteboard tag.