Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313995 - Inconsistent license text in feature.properties for cdt.source-feature
Summary: Inconsistent license text in feature.properties for cdt.source-feature
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-releng (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Andrew Gvozdev CLA
QA Contact: Vivian Kong CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 19:21 EDT by Martin Oberhuber CLA
Modified: 2010-07-28 15:29 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-05-21 19:21:12 EDT 
I just installed CDT 7.0rc2 candidate (201005211239) and noticed that in the install wizard there are TWO licenses seen instead of just one. The "Eclipse C/C++ Development Tooling Source 7.0.0.qualifier" feature seems to carry an invalid license.property.
Comment 1 Andrew Gvozdev CLA 2010-05-21 21:33:03 EDT 
I also noticed that. Somehow that "license" property got ending
########### end of license property ##########################################

The license definition in feature.properties is identical to others which are working. Is it a bug in p2 or platform?
Comment 2 Martin Oberhuber CLA 2010-05-22 03:03:08 EDT 
Good you noticed the ending "###". Apparently, the last line of the license text has one "\" too much such that the "###" is merged with the license text. I've also had this in the past. It's an incorrect feature.properties on your end, but very easy to not notice.
Comment 3 Andrew Gvozdev CLA 2010-05-22 13:26:04 EDT 
Fixed on HEAD (7.0). The "###.." ending was not even on its own line. I was looking at wrong plugin at first. You are right and it is foolish to blame platform for anything of course.
Comment 4 CDT Genie CLA 2010-07-28 15:29:30 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 313995: Inconsistent license text in feature.properties for cdt.source-feature

[*] feature.properties 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.platform-feature/sourceTemplateFeature/feature.properties?root=Tools_Project&r1=1.5&r2=1.6