Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313987 - Heap Instance Data Collection
Summary: Heap Instance Data Collection
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Joel Cayne CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: adopter
Keywords:
Depends on:
Blocks: 314543
  Show dependency tree
 
Reported: 2010-05-21 18:01 EDT by Joel Cayne CLA
Modified: 2016-05-05 10:58 EDT (History)
3 users (show)

See Also:
kathy: pmc_approved? (oec)
ernest: pmc_approved+
kathy: pmc_approved? (kathy)
kathy: pmc_approved? (paulslau)
jgwest: pmc_approved+
jgwest: review+


Attachments
Patch for heap instance agent (74.93 KB, patch)
2010-05-22 16:31 EDT, Joel Cayne CLA
no flags Details | Diff
Patch for heap instance agent (75.20 KB, patch)
2010-05-23 15:06 EDT, Joel Cayne CLA
no flags Details | Diff
Build updates for Heap instance data collection (8.11 KB, patch)
2010-05-25 15:39 EDT, Joel Cayne CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Cayne CLA 2010-05-21 18:01:18 EDT
Create an agent to handle Heap Instance Data Collection.
Comment 1 Joel Cayne CLA 2010-05-22 16:31:53 EDT
Created attachment 169591 [details]
Patch for heap instance agent
Comment 2 Joel Cayne CLA 2010-05-22 16:32:29 EDT
Jonathan,
Can you please review?

Thanks!
Comment 3 Joel Cayne CLA 2010-05-23 15:06:50 EDT
Created attachment 169619 [details]
Patch for heap instance agent

Updated the patch to provide the option to return an error string for the result, set a default result for the Raw Monitor Wait and check to show debug information once.
Comment 4 Joel Cayne CLA 2010-05-25 10:31:05 EDT
I would like to request for PMC approval to include the fix of this bug in TPTP
v4.7.0.

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

This is an extension to the Agent Controller profiling agent requested by a consuming product.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

3. Is this a regression or API breakage? Explain.

No.

4. Does this require new API?

Yes. The additional agent code is isolated to this extension and has been tested on both Windows and Linux platforms by myself and Mike.

5. Who performed the code review?

Jonathan

6. Is there a test case attached to the bugzilla record?

No. Existing Profiling functionality should not be impacted by the changes. A test case for this function will be added at a later time.

7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Described above, risk is medium.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
        n/a
Comment 5 Kathy Chan CLA 2010-05-25 10:37:18 EDT
This is requested by a consuming product who will be extending this. This will not affect existing profiling or test functions. 

Requesting PMC approval for TPTP 4.7 RC2.
Comment 6 Joel Cayne CLA 2010-05-25 10:49:12 EDT
Patch checked into HEAD.
Comment 7 Joel Cayne CLA 2010-05-25 15:39:37 EDT
Created attachment 169887 [details]
Build updates for Heap instance data collection
Comment 8 Joel Cayne CLA 2010-05-25 15:43:00 EDT
Binary .class file and makefile changes checked into HEAD.
Comment 9 Joel Cayne CLA 2010-06-11 12:16:14 EDT
Closing.