Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313980 - [launch] done() being called on wrong progress monitor
Summary: [launch] done() being called on wrong progress monitor
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 17:12 EDT by John Cortell CLA
Modified: 2011-06-08 00:54 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-05-21 17:12:35 EDT 
It seems to me the wrong monitor is being done() in

   LaunchConfigurationDelegate.buildProjects(IProject[], IProgressMonitor)

in the finally section. The method should be called on 'pm' not 'localmonitor', unless I'm mistaken. I have not witnessed a problem associated with this, but I strongly suspect the code isn't doing the right thing. Refer to the JavaDoc for 

   SubMonitor.convert(IProgressMonitor, String, int)
Comment 1 Pawel Piech CLA 2011-06-08 00:54:23 EDT 
I read the javadoc and i looked through the implementations... and I still don't know either.  But I'll take the "if it don't broke, don't fix it approach" ;-)  

Please reopen if needed.