Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313968 - org.eclipse.swt.examples.source plugin contains duplicate .java files
Summary: org.eclipse.swt.examples.source plugin contains duplicate .java files
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 15:20 EDT by Grant Gayed CLA
Modified: 2013-07-24 13:08 EDT (History)
5 users (show)

See Also:


Attachments
sources-bundle.log (43.82 KB, text/x-log)
2013-07-24 11:24 EDT, Thanh Ha CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2010-05-21 15:20:02 EDT
Open the org.eclipse.swt.examples.source_<version>.jar plugin in winzip, sort alphabetically by name, and note that each .java file appears twice, once in a tree starting with "src", and again in a tree starting with "swtexamplessrc".  I think the two trees are identical, except that only one of them contains the accompanying non-java files (.gif's, etc.).  SWT's other examples source plugins do not have this problem, only this one.

Also note that this isn't a new problem, this plugin looks the same in 3.5.2.
Comment 1 David Williams CLA 2013-07-24 11:03:14 EDT
I'm not sure if this is still an issue ... but if it is, I think belongs in SWT component ... I seem to recall some on-going work to produce your source bundles for new Tycho/Maven build? 

Though, by all means, if I can help, or if does belong in 'releng' feel free to explain and move back.

Thanks.
Comment 2 Thanh Ha CLA 2013-07-24 11:24:54 EDT
Created attachment 233757 [details]
sources-bundle.log

Happened to have a build open so thought I'd verify this real quick. I can confirm that the issue appears to still be existent. The attached log shows the contents of the source bundle.
Comment 3 Thanh Ha CLA 2013-07-24 11:52:35 EDT
I think this has to do with the fact that build.properties seems to be a little redundant.

src.includes declares that "src/" needs to be included and there's an additional line that says "src/" should be included again as source.swtexamples.jar.


---- snippet ----
src.includes = about.html,\
               doc-html/,\
               src/

source.swtexamples.jar = src/
---- snippet ----


Would it make sense to remove "src/" from src.includes?

(this seems like the simplest solution to me)
Comment 4 Thanh Ha CLA 2013-07-24 11:53:36 EDT
(In reply to comment #3)
> Would it make sense to remove "src/" from src.includes?
> 
> (this seems like the simplest solution to me)

From what I can tell this is what org.eclipse.swt.examples.browser does.
Comment 5 Silenio Quarti CLA 2013-07-24 13:08:52 EDT
This seems to be already fixed in latest: 

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7e8302674ef0e052e0f01c62a01ebb7440f57fc1