313961 – tabledataeditor plug-in doesn't include its schema directory

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313961 - tabledataeditor plug-in doesn't include its schema directory

Summary: tabledataeditor plug-in doesn't include its schema directory

Status:	RESOLVED FIXED

Alias:	None

Product:	Data Tools
Classification:	Tools
Component:	Table Data Editor (show other bugs)
Version:	1.7
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	1.8
Assignee:	Brian Payton
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-05-21 14:30 EDT by Charles Eutsler
Modified:	2010-05-25 03:24 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Charles Eutsler

2010-05-21 14:30:36 EDT

Build Identifier: 20100218-1602

The bin.includes section of the tabledataeditor plug-in's build.properties file doesn't include the "schema/" directory.  This makes it difficult to have a plug-in implement the externalRunQuery extension point.

Reproducible: Always

Steps to Reproduce:
1. In the manifest editor of a plug-in that includes tabledataeditor as a dependency, add org.eclipse.datatools.sqltools.tabledataeditor.externalRunQuery in Extension tab.
2. Observe that the "New" menu is not present when right-clicking on the extension point name.

There should be a "New" menu that includes the external_query_adapter element.

Comment 1 Brian Payton

2010-05-24 21:25:44 EDT

Thanks for pointing this out.  There are a few SQL Dev Tools plugins that don't include the schema directory in their bin.includes.  Here they are:
- org.eclipse.datatools.sqltools.data.ui
- org.eclipse.datatools.sqltools.debugger.core
- org.eclipse.datatools.sqlscrapbook
- org.eclipse.datatools.tabledataeditor

I will go ahead and update the build.properties file for those plugins.

Comment 2 Brian Payton

2010-05-25 03:24:22 EDT

Checked in change, tagged to v201005250945.