Description Oleg Besedin 2010-05-21 13:43:19 EDT

Created attachment 169530 [details]
Illustrative patch - not meant to be applied - just shows the problem

About 30% of the time we spent to switch between the editors is spent in injection and processing of CSS attributes.

1)
The CSS engine methods, such as CSSPropertyInnerKeylineSWTHandler#applyCSSProperty() seem to create unnecessary contexts on every editor tab switch.

The common pattern for AbstractCSSPropertySWTHandler is:

IEclipseContext childContext = context.createChild();
childContext.set("innerKeyline", newColor);
ContextInjectionFactory.inject(renderer, childContext); 

I don't know the surrounding code, but unless it is doing something very special, the following woudl do the same:

((IEclipseContext) appContext).set("innerKeyline", newColor);

without creating a new child context and injecting it.

I'll attach an illustrative patch were I changed a few classes.

====
2)
The other strange thing is CSSPropertyTabRendererSWTHandler#applyCSSProperty(). That method is called several of times on tab switching (6 times for my compatibility workbench), and every time it creates a new context, a new CTabFolderRenderer class, and injects the new context into that new class.