Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313943 - [hovering] Java source hovers not readable using Ubuntu 10.04 (white-on-black tooltips)
Summary: [hovering] Java source hovers not readable using Ubuntu 10.04 (white-on-black...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.6.1   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 309334 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-21 13:01 EDT by Markus Keller CLA
Modified: 2012-01-09 11:54 EST (History)
5 users (show)

See Also:
daniel_megert: review+

Attachments
Fix (5.13 KB, patch)
2010-05-21 13:01 EDT, Markus Keller CLA 		no flags Details | Diff
Fix for 3.6.1 (5.39 KB, patch)
2010-08-17 10:54 EDT, Markus Keller CLA 		no flags Details | Diff
Screenshot (173.69 KB, image/jpeg)
2010-08-26 06:14 EDT, Rajesh CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-05-21 13:01:03 EDT 
Created attachment 169526 [details]
Fix

I20100520-1744, follow-up to bug 312966

Java source hovers are not readable using Ubuntu 10.04 (which uses white-on-black tooltips by default), see e.g. attachment 168593 [details].

The fix is to use a better "System Default" if the brightness of the Java editor default text color is too close to the hover background color (resorting to the editor background color in that case).
Comment 1 Markus Keller CLA 2010-06-23 09:55:05 EDT 
Fixed in HEAD.
Comment 2 Dani Megert CLA 2010-08-12 01:59:54 EDT 
*** Bug 309334 has been marked as a duplicate of this bug. ***
Comment 3 Markus Keller CLA 2010-08-17 10:54:06 EDT 
Created attachment 176793 [details]
Fix for 3.6.1
Comment 4 Markus Keller CLA 2010-08-17 10:59:57 EDT 
Reopening for 3.6.1.
Comment 5 Dani Megert CLA 2010-08-19 02:40:37 EDT 
+1 for 3.6.1 RC2 with a minor change: SourceViewerInformationControl.getVisibleBackgroundColor needs 3.6.1 @since tag and not 3.6. Fixed that in HEAD.
Comment 6 Markus Keller CLA 2010-08-23 07:06:48 EDT 
> SourceViewerInformationControl.getVisibleBackgroundColor needs 3.6.1 @since tag
> and not 3.6.

Fixed for 3.6.1 including the @since tag fix.
Comment 7 Markus Keller CLA 2010-08-26 05:43:43 EDT 
Verified all hovers on M20100825-0800 with Ubuntu 10.04.
Comment 8 Rajesh CLA 2010-08-26 06:14:53 EDT 
Created attachment 177511 [details]
Screenshot


Verified that its no longer white on black but the new colors aren't great either :) See attached image.
Comment 9 Markus Keller CLA 2010-08-26 06:59:02 EDT 
(In reply to comment #8)
> Created an attachment (id=177511)

This bug is about source hovers (hold Shift while hovering in the Java Editor) and change ruler hovers. Bug 313530 was about updating hover colors when they change in the OS.

If the native tooltips on your OS look different from our Javadoc hovers, please file a separate bug and attach screenshots of native hovers (e.g. from gEdit buttons) and of an SWT tooltip (e.g. on a toolbar button) for comparison.