Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313889 - CDORevisionMerger move with indices swapped
Summary: CDORevisionMerger move with indices swapped
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 06:22 EDT by Pascal Lehmann CLA
Modified: 2010-06-29 09:22 EDT (History)
0 users

See Also:

Attachments
proposed patch (930 bytes, patch)
2010-05-21 06:24 EDT, Pascal Lehmann CLA 		stepper: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Lehmann CLA 2010-05-21 06:22:33 EDT 
Build Identifier: 3.0

The visit method for the CDOMoveFeatureDelta calls revision.move with the newValue as source and oldValue as target, which leads to wrong objects moved in remote views.

Reproducible: Always

Steps to Reproduce:
1. open 2 transactions (A and B).
2. move and object in transaction A, change something on the same feature in transation B.
3. commit transaction A and let the ConflictResolver call CDORevisionMerger which then moves the wrong object.
Comment 1 Pascal Lehmann CLA 2010-05-21 06:24:46 EDT 
Created attachment 169487 [details]
proposed patch
Comment 2 Pascal Lehmann CLA 2010-05-21 11:33:48 EDT 
For patch:

1) The number of lines that you added/changed is smaller than 250.
confirmed
2) You are the only author of these changed lines.
confirmed
3) You apply the EPL to these changed lines.
confirmed
Comment 3 Eike Stepper CLA 2010-05-25 03:59:07 EDT 
Thank you Pascal.

Committed to HEAD
Comment 4 Eike Stepper CLA 2010-06-29 04:35:50 EDT 
Available in 3.0 GA:
http://download.eclipse.org/modeling/emf/cdo/updates/3.0-releases/