Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313879 - [Node model] LeafNode.feature is obsolete
Summary: [Node model] LeafNode.feature is obsolete
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 04:33 EDT by Jan Koehnlein CLA
Modified: 2017-09-19 18:09 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Koehnlein CLA 2010-05-21 04:33:17 EDT 
Looks like this was really needed in only the packrat parser. 

You can also access the feature of a leaf node by finding the node of its assignment and reading it from the grammar model. 

As this is a change in API, it will not be fixed in 1.0.
Comment 1 Sebastian Zarnekow CLA 2010-06-25 11:48:58 EDT 
LeafNode.feature was available a long time before the packrat parser. However, as Jan is right with his remark, we should get rid of it and replace it by a derived property. This will save many null-references in the node model and thereby slightly reduce the memory footprint. At least the profile showed a great many of null values for this feature.

See also bug 264846.
Comment 2 Sebastian Zarnekow CLA 2010-12-13 17:14:06 EST 
The rewritten node model does not expose INode#getFeature
Comment 3 Karsten Thoms CLA 2017-09-19 17:58:33 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 4 Karsten Thoms CLA 2017-09-19 18:09:19 EDT 
Closing all bugs that were set to RESOLVED before Neon.0