This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 313848 - about.html not included in build.properties
Summary: about.html not included in build.properties
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Raghunathan Srinivasan CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 01:29 EDT by Raghunathan Srinivasan CLA
Modified: 2017-12-19 13:27 EST (History)
2 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
neil.hauge: pmc_approved+
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: review+

Attachments
Patch (3.08 KB, text/plain)
2010-05-21 01:29 EDT, Raghunathan Srinivasan CLA 		no flags Details
Test Feature license (2.46 KB, text/plain)
2010-05-21 12:08 EDT, Raghunathan Srinivasan CLA 		no flags Details
Updated Fix for license in test feature (2.46 KB, text/plain)
2010-05-21 15:20 EDT, Raghunathan Srinivasan CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raghunathan Srinivasan CLA 2010-05-21 01:29:23 EDT 
Created attachment 169456 [details]
Patch

From the build :
# Missing pattern or file: about.html in dir: org.eclipse.jst.jsf.facesconfig.tests_1.1.2.v20100428
# Missing pattern or file: about.html in dir: org.eclipse.jst.jsf.facesconfig.ui.test_1.1.0.v20100428
# Missing pattern or file: about.html in dir: org.eclipse.jst.jsf.validation.el.tests_1.2.0.v20100428
# Missing pattern or file: about.html in dir: 
# Missing pattern or file: about.html in file: org.eclipse.jst.jsf.common.runtime.tests_1.1.0.v20100428.jar
# Missing pattern or file: about.html in file: org.eclipse.jst.jsf.facelet.ui_1.0.0.v20100510.jar
Comment 1 Raghunathan Srinivasan CLA 2010-05-21 01:32:36 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
Mission about.html files in build
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
No 
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Manual
* Give a brief technical overview. Who has reviewed this fix? 
See description
* What is the risk associated with this fix?
none
Comment 2 Raghunathan Srinivasan CLA 2010-05-21 12:08:16 EDT 
Created attachment 169518 [details]
Test Feature license
Comment 3 Raghunathan Srinivasan CLA 2010-05-21 12:11:26 EDT 
Update license in the JSF Teast feature, though, I couldn't discern the issue with the current license. I copied the license from one of the 'correct' features. Please review to see if I have addressed the issue.
Comment 4 David Williams CLA 2010-05-21 15:15:32 EDT 
(In reply to comment #3)
> Update license in the JSF Teast feature, though, I couldn't discern the issue
> with the current license. I copied the license from one of the 'correct'
> features. Please review to see if I have addressed the issue.

I think it is failing because in your feature.xml file, you have %feature.license, instead of %license. 

And, in case you are tempted to deviate from the norm :) it really does have to be %license ... you can not change feature.properties file to match feature.license, the feature.properties must be 'license' as it is now. 

Thank you for attending.
Comment 5 Raghunathan Srinivasan CLA 2010-05-21 15:20:30 EDT 
Created attachment 169550 [details]
Updated Fix for license in test feature
Comment 6 Raghunathan Srinivasan CLA 2010-05-25 19:52:50 EDT 
Fixed in S-3.2.0RC3-20100525145526
Comment 7 Eclipse Genie CLA 2017-12-18 20:15:42 EST 
New Gerrit change created: https://git.eclipse.org/r/114223