Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313806 - Export all debug packages
Summary: Export all debug packages
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 15:58 EDT by Nobody - feel free to take it CLA
Modified: 2010-07-28 15:29 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2010-05-20 15:58:58 EDT
According to http://wiki.eclipse.org/Export-Package all packages must be exported.
Comment 1 Nobody - feel free to take it CLA 2010-05-20 16:41:38 EDT
Fixed.
Comment 2 John Cortell CLA 2010-05-20 17:24:14 EDT
Mikhail, I think you probably don't have a baseline defined. I'm getting a number of API Tooling errors now (missing @since tags). They're all in public (non-interal) packages, so I'm just going to assume that these are API-ready and add the @since tags.
Comment 3 Nobody - feel free to take it CLA 2010-05-20 17:44:27 EDT
(In reply to comment #2)
> Mikhail, I think you probably don't have a baseline defined. I'm getting a
> number of API Tooling errors now (missing @since tags). They're all in public
> (non-interal) packages, so I'm just going to assume that these are API-ready
> and add the @since tags.
There were some not exported public packages. Sorry, I didn't realize that it would affect the API. I'll revert it, it's not a good time for API chnages.
Comment 4 John Cortell CLA 2010-05-20 17:47:19 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > Mikhail, I think you probably don't have a baseline defined. I'm getting a
> > number of API Tooling errors now (missing @since tags). They're all in public
> > (non-interal) packages, so I'm just going to assume that these are API-ready
> > and add the @since tags.
> There were some not exported public packages. Sorry, I didn't realize that it
> would affect the API. I'll revert it, it's not a good time for API chnages.

Well, the packages really need to be exported. If they're not API ready, then they should be marked as not visible to downstream plugins, but that's Marc's call (they're in dsf-gdb, if I remember correctly). If we go down that route, the classes should have a comment at the top indicating they're provisional.
Comment 5 Nobody - feel free to take it CLA 2010-05-20 18:02:10 EDT
John, as I can see, you have already made some changes. Is that enough?
Comment 6 John Cortell CLA 2010-05-20 18:07:06 EDT
(In reply to comment #5)
> John, as I can see, you have already made some changes. Is that enough?

Yep. I said I would in comment # 2. That fixes the errors. However, Marc should review that the newly exposed stuff is API ready. I was assuming it was, but you know what they say about assuming. Unfortunately, I forgot to create a patch file since the changes were just decorative in nature. I'll update this bug with the files and versions once they appear in the CDT CVS report.
Comment 7 Nobody - feel free to take it CLA 2010-05-20 18:20:10 EDT
(In reply to comment #6)
> Yep. I said I would in comment # 2. That fixes the errors. However, Marc should
> review that the newly exposed stuff is API ready. I was assuming it was, but
> you know what they say about assuming. Unfortunately, I forgot to create a
> patch file since the changes were just decorative in nature. I'll update this
> bug with the files and versions once they appear in the CDT CVS report.
Thanks John. I owe you another drink.
Comment 8 Marc Khouzam CLA 2010-05-21 08:53:17 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > John, as I can see, you have already made some changes. Is that enough?
> 
> Yep. I said I would in comment # 2. That fixes the errors. However, Marc should
> review that the newly exposed stuff is API ready. I was assuming it was, but
> you know what they say about assuming. 

I hadn't realized some of these packages were not exported, so I was considering everything not marked 'internal' as an existing public API.  This change just makes it official :-)
Comment 9 CDT Genie CLA 2010-07-28 15:29:05 EDT
*** cdt cvs genie on behalf of mkhodjai ***
 Bug 313806 -  Export all debug packages.

[*] MANIFEST.MF 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.11&r2=1.12

[*] MANIFEST.MF 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.16&r2=1.17

[*] MANIFEST.MF 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/jtag/org.eclipse.cdt.debug.gdbjtag.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.11&r2=1.12

[*] MANIFEST.MF 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.9&r2=1.10

[*] MANIFEST.MF 1.26 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.25&r2=1.26

[*] MANIFEST.MF 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.launch/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.16&r2=1.17

[*] MANIFEST.MF 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.search/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.5&r2=1.6

[*] MANIFEST.MF 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.transport/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.5&r2=1.6

[*] VerboseModeChangedEvent.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/ui/console/VerboseModeChangedEvent.java?root=Tools_Project&r1=1.1&r2=1.2
[*] MiConsolePageParticipant.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/ui/console/MiConsolePageParticipant.java?root=Tools_Project&r1=1.3&r2=1.4

[*] MANIFEST.MF 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.17&r2=1.18

[*] MacOSMIEnvironmentCD.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/macos/MacOSMIEnvironmentCD.java?root=Tools_Project&r1=1.2&r2=1.3

[*] MILogActionEnabler.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/breakpoint/actions/MILogActionEnabler.java?root=Tools_Project&r1=1.2&r2=1.3
[*] MIResumeActionEnabler.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/breakpoint/actions/MIResumeActionEnabler.java?root=Tools_Project&r1=1.2&r2=1.3
[*] BreakpointActionAdapter.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/breakpoint/actions/BreakpointActionAdapter.java?root=Tools_Project&r1=1.1&r2=1.2