Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313744 - SimpleArtifactRepository does not allow the user to limit the number of threads used for downloads
Summary: SimpleArtifactRepository does not allow the user to limit the number of threa...
Status: CLOSED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.6.1   Edit
Assignee: Matthew Piggott CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 11:02 EDT by Matthew Piggott CLA
Modified: 2011-04-26 16:42 EDT (History)
3 users (show)

See Also:
pascal: review+

Attachments
Add user control for max threads (5.09 KB, patch)
2010-05-20 11:02 EDT, Matthew Piggott CLA 		tjwatson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Piggott CLA 2010-05-20 11:02:41 EDT 
Created attachment 169359 [details]
Add user control for max threads

Currently there isn't a way for the user to limit the number of concurrent downloads made by the SimpleArtifactRepository, however it is possible for the repository owner to limit the number of concurrent connections, really the user should have the same control.

The attached patch uses the minimum of the user and repository settings, in the event they are not set the default value is considered.  I've also written some tests for the getMaximumThreads method.
Comment 1 Pascal Rapicault CLA 2010-08-18 12:20:00 EDT 
Patch reviewed and committed in HEAD and 3.6.x.
Comment 2 DJ Houghton CLA 2010-09-16 12:03:17 EDT 
There was a problem with tagging HEAD and this won't appear in integration builds until the first build after 3.7 M2.