Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313688 - Photran should support spell checking
Summary: Photran should support spell checking
Status: CLOSED WONTFIX
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Editor & Outline View (show other bugs)
Version: 5.0   Edit
Hardware: PC Linux
: P5 minor (vote)
Target Milestone: ---   Edit
Assignee: Photran Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 06:29 EDT by Philip Mason CLA
Modified: 2010-06-21 15:07 EDT (History)
1 user (show)

See Also:


Attachments
Fortran source file (1.35 KB, application/octet-stream)
2010-05-20 06:29 EDT, Philip Mason CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Mason CLA 2010-05-20 06:29:26 EDT
Created attachment 169305 [details]
Fortran source file

Seem to get an incorrect spell checking error (red squiggle) under function name "itoa" (line 30), function "itoa2" (line 31) is OK though. See sample FORTRAN code attached.
Comment 1 Jeffrey Overbey CLA 2010-05-20 12:22:06 EDT
Hi Philip,

I believe you're getting the error on itoa but not itoa2 because the default settings for the spell checker (Window > Preferences > General > Editors > Text Editors > Spelling) include ignoring words with digits.

Anyway Photran does not contribute anything to the spell checker -- the Eclipse platform spell checks the text in the editor, and we basically stay out of the way.

You could consider creating a custom spell checking dictionary if there are certain errors (like this) that you want to suppress.

Hope that helps.  Thanks for the bug report.

Jeff
Comment 2 Philip Mason CLA 2010-05-21 04:48:34 EDT
Hi,

My understanding is that the spell checker should only apply to strings and
comments, not variable/function names which typically won't be in a dictionary.

Incidentally, if I turn off the spell checker's "ignoring words with digits" option there is no change, "itoa2" is OK, but "itoa" is not.

NOTE: Strings using single quotes don't seem to get spell checked, whereas
ones using double quotes do, see below:

print*,"hello mister Ploq"  !Ploq is mis-spelt
print*,'hello mister Ploq'  !Ploq is spelt OK

Something doesn't seem quite right,

Philip
Comment 3 Jeffrey Overbey CLA 2010-05-21 10:07:01 EDT
Interesting.  As I mentioned, Photran doesn't actually do anything to affect spell checking one way or the other.  It may be that spell checking is being (unintentionally) "contributed" to our editor by CDT.  It looks like we would need to either (1) disable this altogether or (2) override the spelling engine to make it correctly recognize the different partitions in Fortran code.

References:

CDT spell checker contribution (based on JDT):
https://bugs.eclipse.org/190512

Platform spelling support (move from JDT to the Platform):
https://bugs.eclipse.org/185695
Comment 4 Jeffrey Overbey CLA 2010-06-17 10:44:30 EDT
We're closing this bug *for now*, but we are planning on looking at it again later.  We're just closing bugs that aren't on the medium-term agenda.  This feature has been added to the wishlist on the Photran wiki at http://wiki.eclipse.org/PTP/photran/wishlist.
Comment 5 Jeffrey Overbey CLA 2010-06-21 15:07:22 EDT
Bug 185695: A Platform spelling engine has been targeted for Eclipse 3.7 -- we should see what extension points that provides, assuming it actually happens