Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313653 - [dstore] Not Secured using SSL message appears twice per connect
Summary: [dstore] Not Secured using SSL message appears twice per connect
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 02:19 EDT by Masao Nishimoto CLA
Modified: 2010-05-28 12:12 EDT (History)
2 users (show)

See Also:
kjdoyle: review+

Attachments
patch to pass back alerted variable in return value (2.71 KB, patch)
2010-05-26 16:22 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masao Nishimoto CLA 2010-05-20 02:19:29 EDT 
Connecting to any host system results in the "Connection MVS108 has not been secured using SSL. Proceed anyway?" message appearing twice for each connection.
Comment 1 David McKnight CLA 2010-05-21 13:22:19 EDT 
Does this happen for all kinds of connections (i.e. unix) or just z/OS connections?
Comment 2 Masao Nishimoto CLA 2010-05-23 20:45:01 EDT 
It happens for Unix connection, too, if daemon connection is used.  The message is displayed from the following methods.

DStoreConnectorService.connectWithDaemon()
DStoreConnectorService.initializeConnection()

Setting alertedNONSSL in connectWithDaemon() has no effect to the value in the caller.
Comment 3 David McKnight CLA 2010-05-25 16:33:55 EDT 
(In reply to comment #2)
> It happens for Unix connection, too, if daemon connection is used.  The message
> is displayed from the following methods.
> 
> DStoreConnectorService.connectWithDaemon()
> DStoreConnectorService.initializeConnection()
> 
> Setting alertedNONSSL in connectWithDaemon() has no effect to the value in the
> caller.

When I connect and press "Yes" in response to the prompt, I don't see a second prompt.  However, when I connect and press "No" in response to the prompt, I do see a second prompt.  Is this the case for you or does it happen regardless of hitting "Yes" or "No"?
Comment 4 Masao Nishimoto CLA 2010-05-25 20:10:59 EDT 
When I press "No", I see no second prompt.  When I press "Yes", I see a second prompt.
Comment 5 Martin Oberhuber CLA 2010-05-25 23:36:58 EDT 
Perhaps a translation problem on the buttons? Are you running on en_US locale?
Comment 6 Masao Nishimoto CLA 2010-05-26 00:56:28 EDT 
I'm running on en_US locale. "Yes" to proceed anyway, and "No" to not.
Comment 7 Martin Oberhuber CLA 2010-05-26 14:25:57 EDT 
I have also seen the duplicate prompt today (with TM 3.2rc2 / Eclipse 3.6rc2 on Windows XP host / Linux target, with remote dstore daemon).
Comment 8 David McKnight CLA 2010-05-26 15:53:28 EDT 
I originally tried with the 3.0.3+ driver but with the HEAD stream version I can reproduce it in both the "Yes" and "No" case.
Comment 9 David McKnight CLA 2010-05-26 16:22:45 EDT 
Created attachment 170096 [details]
patch to pass back alerted variable in return value
Comment 10 David McKnight CLA 2010-05-27 12:55:23 EDT 
Kevin, could you please review the patch?
Comment 11 Kevin Doyle CLA 2010-05-28 11:45:47 EDT 
Review +.
Comment 12 David McKnight CLA 2010-05-28 12:00:53 EDT 
Thanks Kevin.  I've committed the change to cvs.
Comment 13 Martin Oberhuber CLA 2010-05-28 12:12:57 EDT 
Applied, tested, released > I20100528.
Thanks.