Description Sheryl 2010-05-19 20:36:46 EDT

Build Identifier: 3.6.0 I20100312-1448

I'm running a headless PDE build with 3.6 M6. I have 2 issues:

1. In publish.bin.parts target in the pde generated build.xml of a plugin, there is a task :
        <eclipse.versionReplacer path="${build.result.folder}" version="<version>"/>

This overwrites the plugin META-INF/MANIFEST because ${build.result.folder} is equal to ${basedir}. As a result, the next build doesn't pick up a new qualifier for the plugin version.

If I set the customBuildCallbacks property in the plugin build.properties, the task changes to:
        <eclipse.versionReplacer path="${build.result.folder}/<plugin id>_<version>" version="<version>"/>

This works because the replacement is done not in the src folder, but in a different folder.
        
2. Also, the clean target of plugin build.xml doesn't delete this folder: 

        <mkdir dir="${build.result.folder}/<plugin id>_<version>"/>


The workaround I have is to delete all the plugins after a build and re-fetch. This adds to the build time.

Reproducible: Always

Steps to Reproduce:
1. Run a eclipse headless PDE build using an ant task -        
 <exec executable="java" errorproperty="result.code">
            <arg line="-jar ${eclipse.base}/plugins/org.eclipse.equinox.launcher_1.1.0.v20100307.jar -application org.eclipse.ant.core.antRunner -buildfile ${eclipse.base}/plugins/org.eclipse.pde.build_3.6.0.v20100311-1400/scripts/build.xml
                -DforceContextQualifier=104
                -Dbuilder=${build.config.dir}
                -DbuildDirectory=${buildDirectory}"/>
        </exec>

2. After the build completes, the plugin MANIFEST has changed.