Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313619 - V1 Validator extension point changes for performance
Summary: V1 Validator extension point changes for performance
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Hari Shankar CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on: 313384
Blocks:
  Show dependency tree
 
Reported: 2010-05-19 15:58 EDT by Hari Shankar CLA
Modified: 2010-05-19 23:56 EDT (History)
2 users (show)

See Also:
hshanka: pmc_approved? (david_williams)
hshanka: pmc_approved? (raghunathan.srinivasan)
hshanka: pmc_approved? (naci.dai)
deboer: pmc_approved+
hshanka: pmc_approved? (neil.hauge)
hshanka: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
Patch (3.02 KB, patch)
2010-05-19 15:58 EDT, Hari Shankar CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hari Shankar CLA 2010-05-19 15:58:30 EDT 
Build Identifier: 32

This patch specifies the runStrategy attribute to the v1 validator extension point. By doing so, we are ensuring that the validator runs only once per project, and not once per resource, thus achieving significant performance gains during manual validation.

Reproducible: Always
Comment 1 Hari Shankar CLA 2010-05-19 15:58:52 EDT 
Created attachment 169206 [details]
Patch

Patch
Comment 2 Hari Shankar CLA 2010-05-19 16:04:41 EDT 
This patch depends on  Bug 313384.
Comment 3 Chuck Bridgham CLA 2010-05-19 16:17:40 EDT 
approved
Comment 4 Hari Shankar CLA 2010-05-19 16:24:45 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This fixes a performance issue that causes significant impact on customer workspaces (> 20 mins to validate a project)

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No known workarounds.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Tested on all java ee modules by invoking manual validation, and ensuring that the appropriate validator is called only once per project

    * Give a brief technical overview. Who has reviewed this fix? 
This fix has been reiviewed by Chuck Bridgham

    * What is the risk associated with this fix? 
This patch basically limits the call to the Java EE validators to once per project. Hence the validation still happens, and any markers are shown as appropriate.
Comment 5 Carl Anderson CLA 2010-05-19 17:52:17 EDT 
Committed to HEAD for WTP 3.2 RC2