Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313609 - Border items are always clipped
Summary: Border items are always clipped
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.3   Edit
Hardware: PC Windows XP
: P3 major
Target Milestone: 2.3   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-19 15:21 EDT by Alex Boyko CLA
Modified: 2010-07-19 12:30 EDT (History)
1 user (show)

See Also:

Attachments
patch (2.08 KB, patch)
2010-05-19 15:21 EDT, Alex Boyko CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2010-05-19 15:21:54 EDT 
Created attachment 169194 [details]
patch

Due to Draw2D fix for Bug 312352 there is a regression in GMF on border items clipping.

New clipping strategy looks for rectangle intersections of child figure clipping rectangles with graphics clipping rectangle, while before there was one check for intersection and the check was checking child figure intersection with the graphics clipping rectangle.
BorderItemcontainerFigure#getBounds() == bounds, but BorderItemcontainer#intersects(Rectangle) == extendedBounds.intersects(Rectangle).

I don't see how IClippingStrategy can account for this... therefore i suggest adopting IClippingStrategy on BorderedNodeFigure.

I tested the patch and it looks ok to me.
Comment 1 Alex Boyko CLA 2010-05-20 22:21:31 EDT 
Delivered the fix for 2.3 RC2
Comment 2 Eclipse Webmaster CLA 2010-07-16 23:38:16 EDT 
[target cleanup] 2.3 RC was the original target milestone for this
bug
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:30:18 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug