Community
Participate
Working Groups
Build Identifier: WTP 3.2 RC1 I saw the following accessibility and display issues in the Deployment Assembly page: 1. When you add a new project reference page to a web project, the Add Project Reference page has wrong tab order. It goes first to the "web lib reference" checkbox, then to the table. 2. When you add a new reference to a web project, the icon and label for 'Project Reference' are inconsistent with those displayed in the new reference wizard for other projects. 3. The buttons in the Manifest Entries tab don't have hot keys. 4. The Add manifest entry dialog has wrong tab order 5. In the manifest entries table, there should be a label above the table for accessibility purposes. Reproducible: Always
Created attachment 169184 [details] Patch Adding the following fixes (covers all issues mentioned in the defect description): - The ordering of how the displayed items were declared was changed to fix tab ordering. - The messages.properties was modified to add hot keys - A 'Manifest Entries:' label was added on top of the table in the Manifest Entry tab and Add Manifest Entry wizard. - The extension in the org.eclipse.jst.servlet.ui/plugin.xml that declares the label and icon for the 'Project Reference' node in the add new reference wizard was updated.
Created attachment 169185 [details] Icon For consistency with other 'Project' nodes displayed in the 'New Reference Wizard', the prj_obj.gif icon (obtained from org.eclipse.wst.common.modulecore.ui) needs to be added.
Marking as NLS due to changes to the properties files.
approved - These changes address all of these issues found during our internal usability and NL testing
I approve of this patch
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This defect fixes accessibility issues, incorrect tab ordering and display inconsistencies in the deployment assembly page (See defect description). This window is fairly new and this issues should be fixed since they are easily noticeable by users. * Is there a work-around? If so, why do you believe the work-around is insufficient? No. * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manually tested deployment assembly window for different project types. * Give a brief technical overview. Who has reviewed this fix? This patch does the following: - The order of how some display items in the 'new project reference wizard', and 'add new manifest wizard' (which open from the 'deployment assembly' preference page) are declared has been changed in order to fix tab ordering in these windows. - The messages.properties was modified to add hot keys - A 'Manifest Entries:' label was added on top of the table in the Manifest Entry tab (in the deployment assembly preference page) and Add Manifest Entry wizard. - The extension in the org.eclipse.jst.servlet.ui/plugin.xml that declares the label and icon for the 'Project Reference' node in the add new reference wizard was updated to make it consistent with the default. Chuck, and Carl have reviewed this patch. * What is the risk associated with this fix? I believe the risk is minimal since the fix mostly modifies the ordering in which display elements are declared, changes some label values to add hot keys, adds a new label to allow for a hot key to redirect to the manifest entries table, and modifies the label and icon displayed for a tree node (a new icon was added to the plugin).
Committed to HEAD for WTP 3.2 RC2
