Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313564 - Adding arbitrary output entry to build.properties creates unecessary bin.includes entry
Summary: Adding arbitrary output entry to build.properties creates unecessary bin.incl...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 309157
Blocks: 313175
  Show dependency tree
 
Reported: 2010-05-19 12:13 EDT by Curtis Windatt CLA
Modified: 2010-05-21 11:34 EDT (History)
3 users (show)

See Also:
darin.eclipse: review+
curtis.windatt.public: review+

Attachments
Patch (1.62 KB, patch)
2010-05-19 16:38 EDT, Ankur Sharma CLA 		no flags Details | Diff
update (6.29 KB, patch)
2010-05-19 16:56 EDT, Darin Wright CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-05-19 12:13:02 EDT 
+++ This bug was initially created as a clone of Bug #309157 +++

I20100413-1521

Steps:

* In any build.properties files, add an additional output entry that refers to nothing on the bundle classpath. For example:

output.some.jar = .

* No errors appears even though "some.jar" does not exist on the bundle classpath

Errors are properly flagged, however, I get strange secondary error with this
patch. For example:

* check out "org.eclipse.debug.core" from HEAD
* add "source.junk = junk/" to the build.properties

I get two errors:

An entry for junk/ is required in bin.includes    build.properties   
/org.eclipse.debug.core    line 11    Plug-in Problem
The specified library 'junk' is not on the plug-in classpath.   
build.properties    /org.eclipse.debug.core    line 21    Plug-in Problem


The first is wrong.
Comment 1 Ankur Sharma CLA 2010-05-19 16:38:28 EDT 
Created attachment 169220 [details]
Patch
Comment 2 Darin Wright CLA 2010-05-19 16:56:21 EDT 
Created attachment 169228 [details]
update

This is an update for this bug and bug 309157. It adds a null check (just to be safe), and changed "plug-in" to "bundle" in the error message.
Comment 3 Curtis Windatt CLA 2010-05-19 17:08:17 EDT 
Fixed as part of bug 309157
Comment 4 Curtis Windatt CLA 2010-05-19 17:09:31 EDT 
There was an extra space in the resource string that was changed.  I fixed it in HEAD.
Comment 5 Darin Wright CLA 2010-05-21 11:34:57 EDT 
Verified