Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313510 - "Import specific versions(s) shown below" in Import Projects from CVS dialog needs polish
Summary: "Import specific versions(s) shown below" in Import Projects from CVS dialog ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-19 08:18 EDT by Dani Megert CLA
Modified: 2011-04-07 10:16 EDT (History)
5 users (show)

See Also:

Attachments
Picture of Import Projects from CVS dialog (14.51 KB, image/png)
2010-05-19 08:18 EDT, Dani Megert CLA 		no flags Details
Patch for handling singular and plural label (3.96 KB, patch)
2011-04-07 06:45 EDT, Ankur Sharma CLA 		daniel_megert: review-
Details | Diff
Fix (3.07 KB, patch)
2011-04-07 10:05 EDT, Dani Megert CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-05-19 08:18:08 EDT 
N20100517-2000.

The string "Import specific versions(s) shown below" is misleading because in some scenarios I don't see any version in the dialog, hence I have no clue about which version it talks (see attached picture).

It uses "(s)" which is a blooper: we always use correct singular or plural wording depending on the number of items.
Comment 1 Dani Megert CLA 2010-05-19 08:18:34 EDT 
Created attachment 169097 [details]
Picture of Import Projects from CVS dialog
Comment 2 Darin Wright CLA 2010-05-19 09:15:45 EDT 
The SCMURL's contain version information when produced from I-builds, releases, etc. The SCMURL's in a nightly don't contain version info, since they are built from HEAD. The wizard could likely be enhanced to recognize this.
Comment 3 Ankur Sharma CLA 2011-04-07 06:45:42 EDT 
Created attachment 192719 [details]
Patch for handling singular and plural label
Comment 4 Ankur Sharma CLA 2011-04-07 06:50:38 EDT 
The version is correctly mentioned now. Attaching the patch for correct label handling and forwarding to Team (own owns this wizard page now).
Comment 5 Dani Megert CLA 2011-04-07 10:03:15 EDT 
Comment on attachment 192719 [details]
Patch for handling singular and plural label

The patch is not really good:
1. it leaves the "(s)" in the string
2. it creates a new key but uses the same string from an existing key
3. it does not fix the issue that the version is not shown if HEAD is chosen
Comment 6 Dani Megert CLA 2011-04-07 10:03:28 EDT 
Let me fix this.
Comment 7 Dani Megert CLA 2011-04-07 10:05:21 EDT 
Created attachment 192742 [details]
Fix
Comment 8 Dani Megert CLA 2011-04-07 10:07:58 EDT 
Fixed in HEAD.
Available in builds >= N20110407-2000.