Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313485 - Improper message shows up when renamed a file with some unsaved change.[01]
Summary: Improper message shows up when renamed a file with some unsaved change.[01]
Status: VERIFIED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 2.6.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.4.1   Edit
Assignee: Yuxuan Dai CLA
QA Contact: Olga Simakova CLA
URL:
Whiteboard: Non-Auto
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-19 05:07 EDT by Maggie Shen CLA
Modified: 2014-09-10 19:15 EDT (History)
4 users (show)

See Also:

Attachments
screen shot (11.43 KB, image/jpeg)
2010-05-19 05:07 EDT, Maggie Shen CLA 		no flags Details
Fix-the-bug-that-improper-message-shows-up-when-rename-a-file-with-unsaved-changes.patch (15.89 KB, patch)
2014-03-12 19:45 EDT, Yuxuan Dai CLA 		no flags Details | Diff
Screenshot of New message (97.91 KB, image/jpeg)
2014-09-10 19:15 EDT, Olga Simakova CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maggie Shen CLA 2010-05-19 05:07:10 EDT 
Created attachment 169071 [details]
screen shot

description:
Improper message shows up when renamed a file with some unsaved change.

build id:
2.6.0 v20100519-0630

steps to reproduce:
1. New a library or report, insert some content and do not save.
2. In Resource Explorer, rename the the library or report.

Actual result:
Message shows up that the file is deleted. See attached screen shot.

Expected result:
Please refer to rename file in Navigator.
Comment 1 Yuxuan Dai CLA 2014-03-12 19:45:18 EDT 
Created attachment 240832 [details]
Fix-the-bug-that-improper-message-shows-up-when-rename-a-file-with-unsaved-changes.patch

Fixed the bug that users are asked to close unsaved files before renaming.
Comment 2 Yuxuan Dai CLA 2014-03-13 15:23:52 EDT 
Fixed.
Comment 3 Linda Chan CLA 2014-03-13 17:05:33 EDT 
Pending commit to source repo.
Comment 4 Linda Chan CLA 2014-03-14 19:35:57 EDT 
(In reply to Yuxuan Dai from comment #1)

The attached patch does not seem to have fixed the behavior.  When testing with it, I still got the same Delete File message prompt.
Also, the new java files are missing Copyright header with EPL info.  And the version tolerance pf a plugin dependency should not have specified the 3rd part version number.
Comment 5 Paul Clenahan CLA 2014-06-03 21:32:22 EDT 
This was targeted to be looked at in 4.4 but we were not able to get to it as far as I can tell. Removing Target assignment so that we re-evaluate this for post 4.4.
Comment 6 Yuxuan Dai CLA 2014-08-27 20:40:59 EDT 
Fixed this bug by asking user to close unsaved file before renaming it.
Comment 7 Yuxuan Dai CLA 2014-09-03 14:10:26 EDT 
commit: 373640f5bfd0fce6219436adb9d9fe3b6cb6bc9d
Comment 8 Olga Simakova CLA 2014-09-10 15:08:04 EDT 
This issue has been fixed and verified.  Now user is getting message: "Report will be closed so that it may be updated accordingly.  Do you want to proceed?" (Please see attached screenshot).
Comment 9 Olga Simakova CLA 2014-09-10 19:15:00 EDT 
Created attachment 246937 [details]
Screenshot of New message
Comment 10 Olga Simakova CLA 2014-09-10 19:15:50 EDT 
This item is fixed and verified (see attached screenshot).