Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313412 - [discovery] DiscoveryInstallOperation can install older version of a feature over a newer one
Summary: [discovery] DiscoveryInstallOperation can install older version of a feature ...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: David Dubrow CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 13:56 EDT by David Dubrow CLA
Modified: 2010-05-19 20:33 EDT (History)
4 users (show)

See Also:
steffen.pingel: review+
pascal: review+


Attachments
proposed fix (1.16 KB, patch)
2010-05-18 13:56 EDT, David Dubrow CLA
steffen.pingel: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Dubrow CLA 2010-05-18 13:56:30 EDT
Created attachment 168982 [details]
proposed fix

While working with composite repositories where multiple versions may exist for the same feature, I found a bug in DiscoveryInstallOperation whereby an older version is installed over a newer one if the result of OSGIVersion.compareTo is < -1.
Comment 1 Steffen Pingel CLA 2010-05-18 17:20:22 EDT
Thanks for the bug report and patch, David. The fix looks right to me. 

Pascal, can you take a quick look as well?
Comment 2 Steffen Pingel CLA 2010-05-19 20:33:11 EDT
Thanks. Patch released.