Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313381 - When launching with features, pressing select features button when no features available should warn user
Summary: When launching with features, pressing select features button when no feature...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 312646
Blocks:
  Show dependency tree
 
Reported: 2010-05-18 11:46 EDT by Curtis Windatt CLA
Modified: 2010-05-21 10:52 EDT (History)
2 users (show)

See Also:
darin.eclipse: review+
ankur_sharma: review+

Attachments
Fix (2.93 KB, patch)
2010-05-18 11:51 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-05-18 11:46:49 EDT 
1) Open an Eclipse launch config
2) Plug-ins Tab, Launch using features selected below.
3) Select all features
4) Press select features...

We should have a warning message saying that all features have been selected.  A better solution would be to disable the button, however, there is no easy way to do this.  In addition, if the user is only viewing selected plug-ins, there would be no explanation to the user as to why the button was disabled.
Comment 1 Ankur Sharma CLA 2010-05-18 11:50:42 EDT 
Bug #312646 already has the fix for this
Comment 2 Curtis Windatt CLA 2010-05-18 11:51:25 EDT 
Created attachment 168959 [details]
Fix

This is the fix taken from bug 312646, with the resource strings modified.  Puts up a warning message if there is nothing to select.  I had another fix that opened the selection dialog with an error message, but a message dialog is more direct.
Comment 3 Curtis Windatt CLA 2010-05-18 11:52:20 EDT 
Darin, Ankur, please review.
Comment 4 Ankur Sharma CLA 2010-05-18 11:56:21 EDT 
+1
Comment 5 Darin Wright CLA 2010-05-18 14:11:20 EDT 
Applied/Fixed.
Comment 6 Darin Wright CLA 2010-05-21 10:52:24 EDT 
Verified.