Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313354 - [target] Finish button is enabled with nothing selected on add software site wizard
Summary: [target] Finish button is enabled with nothing selected on add software site ...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 09:54 EDT by Curtis Windatt CLA
Modified: 2010-05-21 11:38 EDT (History)
2 users (show)

See Also:
darin.eclipse: review+
ankur_sharma: review+

Attachments
Fix (1.24 KB, patch)
2010-05-19 11:51 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-05-18 09:54:09 EDT 
Found while testing bug 313019

1) Create a new target definition
2) Add new software site
3) Change to the following site:
https://build.eclipse.org/hudson/job/emf-cdo-integration/lastSuccessfulBuild/artifact/result/site.p2/
Result:
Nothing is selected but the finish button is enabled.  Hitting finish will result in a empty container.  Selecting, then unselecting it will result in an error message saying that at least one item must be selected.

It appears the removing the current site and hitting enter is enough to enable finish.
Comment 1 Curtis Windatt CLA 2010-05-19 11:51:39 EDT 
Created attachment 169144 [details]
Fix

Adds a separate case to the pageChanged() method.  We ensure that finish is disabled when changing sites or performing another action that could affect the checked contents without activating the check state listener.
Comment 2 Curtis Windatt CLA 2010-05-19 11:52:09 EDT 
Darin, Ankur, please review.
Comment 3 Ankur Sharma CLA 2010-05-19 14:38:23 EDT 
+1
Comment 4 Curtis Windatt CLA 2010-05-19 14:45:07 EDT 
Fixed in HEAD.
Comment 5 Curtis Windatt CLA 2010-05-21 11:38:42 EDT 
Verified.