Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313340 - [EMF Compare] GenericMatchEngine is restricted to XMIResources
Summary: [EMF Compare] GenericMatchEngine is restricted to XMIResources
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: 1.1   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 08:52 EDT by Christian Schneider CLA
Modified: 2011-08-18 04:35 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Schneider CLA 2010-05-18 08:52:37 EDT 
Matching, diffing and merging is restricted to XMIResources by the following code in method doMatch in GenericMatchEngine.java:

if (!structuredOptions.isIgnoringXMIID())
    if (leftResource instanceof XMIResource && rightResource
            instanceof XMIResource) {
        checker.init(leftResource, rightResource);
}

This prohibits proper comparing of XtextResources, for example.

See also http://www.eclipse.org/forums/index.php?t=rview&goto=533818&th=168091
Comment 1 Cedric Brun CLA 2010-05-18 08:58:09 EDT 
That's kind of an overlook, I  fixed it and added unit tests for non XMI resources. The build is going on and should be available in the next hours.

Thanks for your feedback !
Comment 2 Laurent Goubet CLA 2011-08-18 04:01:43 EDT 
Closing this bug now.
Comment 3 Christian Schneider CLA 2011-08-18 04:05:27 EDT 
(In reply to comment #2)
> Closing this bug now.

It works for me :-)
Comment 4 Laurent Goubet CLA 2011-08-18 04:23:38 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Closing this bug now.
> 
> It works for me :-)

Thanks for the feedback :). At least we are sure that it indeed fixed the issue for you :).
Comment 5 Christian Schneider CLA 2011-08-18 04:35:50 EDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Closing this bug now.
> > 
> > It works for me :-)
> 
> Thanks for the feedback :). At least we are sure that it indeed fixed the issue
> for you :).

If you are curious about the result, have a look at
http://rtsys.informatik.uni-kiel.de/~chsch/videokitsaudio.mp4