Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313337 - Improper refactoring and highlight of occurrences of templates and queries
Summary: Improper refactoring and highlight of occurrences of templates and queries
Status: CLOSED FIXED
Alias: None
Product: Acceleo
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 08:48 EDT by Stephane Begaudeau CLA
Modified: 2011-10-12 05:13 EDT (History)
2 users (show)

See Also:

Attachments
Patch (5.53 KB, patch)
2010-05-18 08:50 EDT, Stephane Begaudeau CLA 		no flags Details | Diff
Patch v2.0 (22.33 KB, patch)
2010-05-20 07:16 EDT, Stephane Begaudeau CLA 		mariot.chauvin: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephane Begaudeau CLA 2010-05-18 08:48:27 EDT 
Build Identifier: Build id: I20100429-1549

The highlight occurrences process and the refactoring process will consider as a match templates and queries with the same name even if they have different parameters.

Reproducible: Always

Steps to Reproduce:
If you have a module with two templates like :
[template public myTemplate(e : EClass)]
 hi
[/template]

[template public myTemplate(e : EOperation)]
 hello
[/template]

If you select one template, you will see both templates highlighted. If you refactor one template, both will be refactored.
Comment 1 Stephane Begaudeau CLA 2010-05-18 08:50:10 EDT 
Created attachment 168912 [details]
Patch

Improve the search of occurrences of an element, therefore it corrects both problems. Two templates/Queries are considered equals not only if they have the same name but also the same parameters.
Comment 2 Jonathan MUSSET CLA 2010-05-19 10:41:51 EDT 
Change IPlog flag.
Comment 3 Stephane Begaudeau CLA 2010-05-20 07:16:42 EDT 
Created attachment 169311 [details]
Patch v2.0

Improvement over the last patch. By correcting the problem, the last patch revealed a bug in the refactoring of templates and variables, it is now corrected.
Comment 4 Jonathan MUSSET CLA 2010-05-20 10:11:39 EDT 
Fixed for Acceleo 3.0 RC2