Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313329 - Cannot close views in inner Eclipse
Summary: Cannot close views in inner Eclipse
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 07:52 EDT by Remy Suen CLA
Modified: 2010-05-25 08:22 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-05-18 07:52:40 EDT 
1. Synch to HEAD.
2. Run your inner.
3. See that views don't have close buttons (that's part one).
4. Activate a view.
5. Ctrl+3 > Close Part
6. An NPE is logged.

2010-05-18 07:51:17.218 Log ErrorException while dispatching event org.osgi.service.event.Event [topic=org/eclipse/e4/ui/model/ui/UIElement/toBeRendered/SET] to handler org.eclipse.e4.ui.services.internal.events.UIEventHandler@73967396
java.lang.NullPointerException
	at org.eclipse.e4.ui.workbench.addons.cleanupaddon.CleanupAddon$2.handleEvent(CleanupAddon.java:70)
	at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:41)
	at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:188)
	at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:198)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:227)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:149)
	at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:139)
	at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78)
	at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39)
	at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:73)
	at org.eclipse.e4.workbench.ui.internal.UIEventPublisher.notifyChanged(UIEventPublisher.java:58)
	at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:380)
	at org.eclipse.e4.ui.model.application.ui.basic.impl.PartImpl.setToBeRendered(PartImpl.java:532)
	at org.eclipse.e4.workbench.ui.internal.PartServiceImpl.hidePart(PartServiceImpl.java:573)
	at org.eclipse.ui.internal.WorkbenchPage.hidePart(WorkbenchPage.java:962)
	at org.eclipse.ui.internal.WorkbenchPage.hidePart(WorkbenchPage.java:986)
	at org.eclipse.ui.internal.WorkbenchPage.hideView(WorkbenchPage.java:1635)
	at org.eclipse.ui.internal.handlers.ClosePartHandler.execute(ClosePartHandler.java:43)
Comment 1 Remy Suen CLA 2010-05-18 09:44:55 EDT 
It seems to me as though the IPresentationEngine's removeGui(MUIElement) is not invoked recursively when a view is closed. It doesn't even look like the part's object is set to 'null' either.
Comment 2 Remy Suen CLA 2010-05-18 12:00:15 EDT 
(In reply to comment #0)
> 3. See that views don't have close buttons (that's part one).

Fixed by bug 313382.
Comment 3 Remy Suen CLA 2010-05-25 08:22:34 EDT 
Looks like this is working now.