313325 – Browser: infinite refresh while browsing FacetSet

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313325 - Browser: infinite refresh while browsing FacetSet

Summary: Browser: infinite refresh while browsing FacetSet

Status:	CLOSED FIXED

Alias:	None

Product:	MoDisco
Classification:	Modeling
Component:	Infrastructure (show other bugs)
Version:	0.8.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	0.8.0
Assignee:	Nicolas Bros
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-05-18 07:15 EDT by Nicolas Bros
Modified:	2010-10-04 13:06 EDT (History)
CC List:	3 users (show)

See Also:

Flags:	nicolas.bros: helios+ hugo.bruneliere: review+

Attachments
patch (12.22 KB, patch) 2010-05-18 08:16 EDT, Nicolas Bros	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nicolas Bros

2010-05-18 07:15:47 EDT

- "Navigate > Open EPackage"
- Choose the EPackage of a FacetSet (for example "http://www.eclipse.org/MoDisco/examples/java/javaTypesCustomizationFacet")
- Expand the FacetSet in the "Instances" panel

The browser refreshes continuously while the FacetSet is expanded in the Instances panel.

This is because FacetSetImpl#getFacets populates an EObjectEList, which triggers model modification notifications, which makes the browser refresh. And each time the browser refreshes, it calls this getFacets method, and so on...

Comment 1 Nicolas Bros

2010-05-18 08:16:36 EDT

Created attachment 168904 [details]
patch

Comment 2 Hugo Bruneliere

2010-05-18 08:21:25 EDT

Hi Nicolas,

You can go ahead with this patch.

Regards,

Hugo

Comment 3 Nicolas Bros

2010-09-27 08:37:07 EDT

I forgot to mark this old bug as fixed.

Comment 4 Hugo Bruneliere

2010-10-04 13:06:44 EDT

The patch has been successfully applied.