Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313242 - [ui] Hard to find "uninstall" UI
Summary: [ui] Hard to find "uninstall" UI
Status: VERIFIED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 17:08 EDT by Evan Hughes CLA
Modified: 2011-01-25 15:12 EST (History)
5 users (show)

See Also:


Attachments
screenshot (49.14 KB, image/png)
2010-08-18 18:37 EDT, Susan McCourt CLA
no flags Details
screenshot if the translated string were not there (56.74 KB, image/png)
2010-08-18 18:45 EDT, Susan McCourt CLA
no flags Details
proposed patch (4.09 KB, patch)
2010-08-18 18:48 EDT, Susan McCourt CLA
no flags Details | Diff
Uninstall link in the install dialog (81.96 KB, image/png)
2010-08-18 21:16 EDT, Pascal Rapicault CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Hughes CLA 2010-05-17 17:08:55 EDT
Build Identifier: I20100429-1549 

I installed a plugin using p2. I wanted to uninstall it. I couldn't find the UI to do that without asking another developer for help. 

It would be helpful if install/uninstall was in roughly the same place in the menu structure. 

Reproducible: Always
Comment 1 Remy Suen CLA 2010-05-18 07:36:20 EDT
This is asked about regularly on IRC.
Comment 2 Pascal Rapicault CLA 2010-05-18 07:55:54 EDT
I was not aware of that. At this point, we have the "already installed" link in install dialog (on the bottom right corner) that leads to the page where you can uninstall.
Do you have any suggestion on to how to remediate this? Add a menu entry, change the wording of the "already installed" link, something else?
Comment 3 Evan Hughes CLA 2010-05-18 08:32:38 EDT
(In reply to comment #2)
> At this point, we have the "already installed" link in
> install dialog (on the bottom right corner) that leads to the page where you
> can uninstall.

   I missed that entirely. 

> Do you have any suggestion on to how to remediate this? Add a menu entry,
> change the wording of the "already installed" link, something else?

   There are two gestures in the "Help" menu that already has two entries dealing with upgrading/installing: "Check for Updates" and "Install New Software". I expected a gesture to manage/uninstall there, so perhaps a third "Uninstall Software" gesture could be added? 

   The other place I expected to find something was in the Preferences dialog. Perhaps there could be a listing of installed features there, with buttons that start the install/uninstall wizards.
Comment 4 Pascal Rapicault CLA 2010-05-19 23:04:16 EDT
Let's review this in the context of 3.6.1
Comment 5 Susan McCourt CLA 2010-08-18 12:39:48 EDT
I don't really like the idea of the uninstall menu item, at least not for 3.6.1, because:
- it seems wrong to add top level menu items in a maintenance release
- it seems wrong to have an "Uninstall" menu item do anything besides bring up the uninstall wizard.  Currently, we permit uninstall when the user is browsing what is installed, and they can look at all the detail about what they have and make decisions.  Then they select the items and the wizard comes up with the things to uninstall.  From a menu, we would have to populate the wizard with "everything that is installed" and then the user would be making decisions there.  We would have to make sure that getting at all the relevant info is as easy as it is from installation details.


So that level of fix feels more like a release change, not a maintenance fix.

For a maintenance fix, we could reword link in the install wizard, and also add a link in the main pref page that guides you to the same page and uses the word "uninstall"
Comment 6 Susan McCourt CLA 2010-08-18 18:37:03 EDT
Created attachment 176944 [details]
screenshot

screenshot showing proposed fix - add an uninstall/update link to the main pref pages
Comment 7 Susan McCourt CLA 2010-08-18 18:45:54 EDT
Created attachment 176946 [details]
screenshot if the translated string were not there

the problem here is that if we don't translate the new string in the maintenance release, then the user would get a random new missing message in the pref page.
Comment 8 Susan McCourt CLA 2010-08-18 18:48:54 EDT
Created attachment 176948 [details]
proposed patch

This is the patch.
Comment 9 Susan McCourt CLA 2010-08-18 18:56:31 EDT
I remember feeling funny about this bug being marked for 3.6.1 because it was discussing new/alternate UI.  We generally avoid that in a maintenance release. Now I remember why.  There is an unwritten rule (thought I saw it mentioned recently but can't find a link) that we don't introduce new strings in a maintenance release.

The problem is that someone shipping with the 3.6 translations on top of 3.6.1 would now get a string that had not been translated, and we could potentially be introducing a bogus string in the pref page as shown in the second screenshot.

Given we have had this problem since 3.5, I suggest we defer this issue to 3.7.

Incidentally, I tried changing the wording of the link on the install wizard (this would not have the problem above whereby a new string is introduced, it would just change its value).  However, I don't think this is a good solution, either, because:
- note that Evan never noticed that link in the first place 
- when I tried rewording the link to mention uninstall, it looked out of place in its current location.

I agree with Evan's point in comment 3.  A user who is looking for uninstall will probably look in the menu, and barring that, will go to the prefs (or we hope to the about dialog).  They probably won't go looking in the install wizard.

Changing milestone to 3.7.
Comment 10 Susan McCourt CLA 2010-08-18 19:05:37 EDT
cc'ing Kit regarding our ability to translate a string in a maintenance release
Comment 11 Kit Lo CLA 2010-08-18 20:57:52 EDT
Susan has already figured out the effect in comment 7.

If Eclips projects all follow the "undocumented" rule of not to introduce any new UI strings in maintenance releases, the languge packs for Eclipse 3.6 will work for all 3.6.x maintenance releases. If a project introduces new UI strings in a maintenance release, we will see effect like what Susan saw in comment 7.

I recommend targetting this UI change to 3.7, unless we can come up with another fix that can resue some existing strings.
Comment 12 Pascal Rapicault CLA 2010-08-18 21:16:01 EDT
Though I understand the reason for this rule, the implication of this unspoken rule is that we will be shipping eclipse-based products that people will have difficulty using (and they'll likely be stuck with this for 2 years).

Susan, as a stop gap for 3.6, can we add a link in the install dialog reusing the text from the "uninstall..." button (see screenshot). Also if we want to add something on the pref page, what about just copying the links from the install dialog page. Even though it may look clunky, at least the user will have guidance.
Comment 13 Pascal Rapicault CLA 2010-08-18 21:16:43 EDT
Created attachment 176955 [details]
Uninstall link in the install dialog
Comment 14 Susan McCourt CLA 2010-12-01 11:27:28 EST
these bugs will be my holiday projects...
Comment 15 Susan McCourt CLA 2010-12-21 16:22:35 EST
Fixed in HEAD >20101221 as shown in comment 6.
(In reply to comment #12)
> Susan, as a stop gap for 3.6, can we add a link in the install dialog reusing
> the text from the "uninstall..." button (see screenshot). Also if we want to
> add something on the pref page, what about just copying the links from the
> install dialog page. Even though it may look clunky, at least the user will
> have guidance.

I don't think that adding more verbage in the install dialog really helps.  See comment 9.

Adding a link that says "uninstall" in the pref page (reusing an existing string) for 3.6.2 is a possibility.
Comment 16 Susan McCourt CLA 2011-01-25 15:12:57 EST
verified on Win7, I20110124-1800