Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313179 - [Usability] Refactor CreateModelWizard
Summary: [Usability] Refactor CreateModelWizard
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Tatiana Fesenko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 276286
Blocks: 267010
  Show dependency tree
 
Reported: 2010-05-17 12:06 EDT by Tatiana Fesenko CLA
Modified: 2010-11-09 16:55 EST (History)
2 users (show)

See Also:
sebastien.gerard: iplog-

Attachments
Initial patch (8.17 KB, patch)
2010-05-17 12:10 EDT, Tatiana Fesenko CLA 		sebastien.gerard: iplog+
Details | Diff
Initial refactoring (12.71 KB, patch)
2010-05-21 10:10 EDT, Tatiana Fesenko CLA 		sebastien.gerard: iplog+
Details | Diff
Javadoc added (6.45 KB, patch)
2010-05-25 06:00 EDT, Tatiana Fesenko CLA 		sebastien.gerard: iplog+
Details | Diff
Refactoring - creation functionality was woved from the Wizard to the corresponding wizard pages (25.04 KB, patch)
2010-05-26 06:17 EDT, Tatiana Fesenko CLA 		sebastien.gerard: iplog+
Details | Diff
Propoes Patch (6.18 KB, patch)
2010-05-26 06:37 EDT, Tatiana Fesenko CLA 		sebastien.gerard: iplog+
Details | Diff
Refactor SelectTemplateWizardPage (28.44 KB, patch)
2010-06-02 06:29 EDT, Tatiana Fesenko CLA 		sebastien.gerard: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tatiana Fesenko CLA 2010-05-17 12:06:27 EDT 
Now CreateModelWizard class has checks like this almost in every method:
if (templatePath != null) {...} else {...}
It(and some other methods ) makes it very difficult to re-use (say, in bug #267010 ' [General] Project creation wizard creating a new project and a new Papyrus model at once')
Refactor the code of  CreateModelWizard for easier re-user
Comment 1 Tatiana Fesenko CLA 2010-05-17 12:10:18 EDT 
Created attachment 168758 [details]
Initial patch
Comment 2 Cedric Dumoulin CLA 2010-05-18 04:51:48 EDT 
The way models are loaded/created is about to be changed  (in less than 2 days). 
Please wait before applying the patch as the model loading changes will certainly impact the CreateModelWizard.
Comment 3 Tatiana Fesenko CLA 2010-05-18 05:32:30 EDT 
> The way models are loaded/created is about to be changed  (in less than 2
> days). 
Cedric, could you provide me a number of this request. It will allow me to track status of the bug and better plan my own work. Thank you.
Comment 4 Tatiana Fesenko CLA 2010-05-19 08:18:32 EDT 
(In reply to comment #3)
> > The way models are loaded/created is about to be changed  (in less than 2
> > days). 
> Cedric, could you provide me a number of this request. It will allow me to
> track status of the bug and better plan my own work. Thank you.
Cedric, any update on this topic? It pauses my work with bug #267010
Comment 5 Cedric Dumoulin CLA 2010-05-19 09:01:41 EDT 
Depends on bug #276286 .
What will change is the way to create models.
Comment 6 Tatiana Fesenko CLA 2010-05-19 09:46:24 EDT 
(In reply to comment #5)
> Depends on bug #276286 .
> What will change is the way to create models.

Cedrik, thank you for providing number of blocking request. It will help me to plan my own work.
Comment 7 Tatiana Fesenko CLA 2010-05-21 10:10:55 EDT 
Created attachment 169501 [details]
Initial refactoring
Comment 8 Tatiana Fesenko CLA 2010-05-21 10:13:01 EDT 
(In reply to comment #7)
> Created an attachment (id=169501) [details]
> Initial refactoring

Remi, could you commit the patch to SVN? Thank you!
Comment 9 Remi Schnekenburger CLA 2010-05-21 10:46:15 EDT 
(In reply to comment #8)
> (In reply to comment #7)
> > Created an attachment (id=169501) [details] [details]
> > Initial refactoring
> 
> Remi, could you commit the patch to SVN? Thank you!

commit in r1693

Thanks!
Comment 10 Tatiana Fesenko CLA 2010-05-25 06:00:46 EDT 
Created attachment 169796 [details]
Javadoc added
Comment 11 Remi Schnekenburger CLA 2010-05-25 06:15:58 EDT 
(In reply to comment #10)
> Created an attachment (id=169796) [details]
> Javadoc added

Committed in r1710.
Thanks!
Comment 12 Tatiana Fesenko CLA 2010-05-26 06:17:51 EDT 
Created attachment 169962 [details]
Refactoring - creation functionality was woved from the Wizard to the corresponding wizard pages
Comment 13 Remi Schnekenburger CLA 2010-05-26 06:23:31 EDT 
(In reply to comment #12)
> Created an attachment (id=169962) [details]
> Refactoring - creation functionality was woved from the Wizard to the
> corresponding wizard pages

Patch applied in r1718.

Thanks ;)
Comment 14 Tatiana Fesenko CLA 2010-05-26 06:37:27 EDT 
Created attachment 169963 [details]
Propoes Patch
Comment 15 Remi Schnekenburger CLA 2010-05-26 06:41:25 EDT 
(In reply to comment #14)
> Created an attachment (id=169963) [details]
> Propoes Patch

Applied in r1720.

Thanks!
Comment 16 Tatiana Fesenko CLA 2010-06-02 06:29:56 EDT 
Created attachment 170771 [details]
Refactor SelectTemplateWizardPage
Comment 17 Remi Schnekenburger CLA 2010-06-02 06:37:00 EDT 
(In reply to comment #16)
> Created an attachment (id=170771) [details]
> Refactor SelectTemplateWizardPage

Applied in r1775.
Thanks ;-)
Comment 18 Tatiana Fesenko CLA 2010-06-07 06:26:31 EDT 
Fixed