Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313115 - NPE in browser.custom.editor.editors.WorkspaceChangeListener
Summary: NPE in browser.custom.editor.editors.WorkspaceChangeListener
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 07:57 EDT by Nicolas Bros CLA
Modified: 2010-10-04 13:05 EDT (History)
3 users (show)

See Also:
nicolas.bros: helios+
hugo.bruneliere: review+

Attachments
stacktrace (1.99 KB, text/plain)
2010-05-17 07:57 EDT, Nicolas Bros CLA 		no flags Details
patch (3.45 KB, patch)
2010-05-17 08:27 EDT, Nicolas Bros CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2010-05-17 07:57:17 EDT 
Created attachment 168715 [details]
stacktrace

see attached stacktrace
Comment 1 Nicolas Bros CLA 2010-05-17 08:00:50 EDT 
This happens when deleting a project from the workspace while a workspace customization is open in the uiCustom editor.
Comment 2 Nicolas Bros CLA 2010-05-17 08:27:52 EDT 
Created attachment 168717 [details]
patch

Apparently, getLocation() returns null for a workspace file that is deleted, and this is what caused the NPE.

This patch fixes the problem by comparing workspace-relative paths instead of absolute locations.
Comment 3 Hugo Bruneliere CLA 2010-05-17 09:43:52 EDT 
Hi Nicolas,

You can go ahead with this patch.

Regards,

Hugo
Comment 4 Nicolas Bros CLA 2010-05-17 10:01:56 EDT 
Thanks! I have committed it to branch 0_8_0.
Comment 5 Hugo Bruneliere CLA 2010-10-04 13:05:26 EDT 
The patch has been successfully applied.