Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313106 - [CommonNavigator] Regression: Show In > Project Explorer removes selection after setting it
Summary: [CommonNavigator] Regression: Show In > Project Explorer removes selection af...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 06:34 EDT by Dani Megert CLA
Modified: 2010-05-20 04:14 EDT (History)
4 users (show)

See Also:
emoffatt: review+
pwebster: review+

Attachments
Proposed patch (1.21 KB, patch)
2010-05-19 14:57 EDT, Francis Upton IV CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-05-17 06:34:10 EDT 
N20100516-2000, broken since 3.6 M7, works in R3.5.x.

First Show In > Project Explorer removes selection after setting it.

1. start with new workspace
2. switch to 'Resource' perspective
3. close the 'Project Explorer'
4. open the 'Navigator'
5. create a simple project 'P'
6. Navigate > Show In > Project Explorer
==> selection is set in the 'Project Explorer' but immediately removed afterwards

Should fix for 3.6 since Show In > is broken
Comment 1 Dani Megert CLA 2010-05-18 03:18:16 EDT 
Increasing severity. Not having the element selected severely impacts the Show In feature.
Comment 2 Francis Upton IV CLA 2010-05-18 10:28:36 EDT 
I will fix this today.
Comment 3 Dani Megert CLA 2010-05-19 09:35:34 EDT 
Any update on the fix? ;-)
Comment 4 Francis Upton IV CLA 2010-05-19 10:10:26 EDT 
(In reply to comment #3)
> Any update on the fix? ;-)
Didn't get to it yesterday, looks like today is going to have to be the day.
Comment 5 Francis Upton IV CLA 2010-05-19 14:57:52 EDT 
Created attachment 169190 [details]
Proposed patch

This problem was introduced by the fix to bug 262096.  This bug fix made a significant change in the way the working set filters were implements. Previously the working set filter (which are part of the Project Explorer and not part of the CN) was a filter directly on the view. So when the CN filters were changed, it updated the view filter and then lost the working set filter. The fix to this was to have the working set filter be implemented as a CN fillter (instead of directly on the view).

In the course of doing this, I created the NavigatorFilterService.updateFilters() method so that when the working set filter changed it could properly refresh. The current version of the updateFilters() also reset the selection, which is causing this problem.

The fix is very conservative (as appropriate for RC2). It moves the reset of the selection back to its original place (the other call of updateFilters()) so that the filter change code continues to work the same. But when the working set code calls updateFilters() it will no longer reset the selection.
Comment 6 Francis Upton IV CLA 2010-05-19 15:00:57 EDT 
BTW - in show annotation the bug number incorrectly shows up as a different number. The number in this bug report (bug 262096) is the correct one.
Comment 7 Francis Upton IV CLA 2010-05-19 15:37:33 EDT 
Released to HEAD 3.6RC2
Comment 8 Dani Megert CLA 2010-05-20 04:14:22 EDT 
Verified in N20100519-2000 that the fix works (didn't review the code).