Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313090 - API Usage: SnapshotOutlinePage illegally implements IContentOutlinePage
Summary: API Usage: SnapshotOutlinePage illegally implements IContentOutlinePage
Status: RESOLVED WORKSFORME
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 313085
  Show dependency tree
 
Reported: 2010-05-17 05:29 EDT by Krum Tsvetkov CLA
Modified: 2013-05-20 09:01 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krum Tsvetkov CLA 2010-05-17 05:29:02 EDT 
As revealed in the API report to bug 313085 the class
org.eclipse.mat.ui.snapshot.views.SnapshotOutlinePage implements org.eclipse.ui.views.contentoutline.IContentOutlinePage, which extends IPage. IPage is marked with  @noimplement
Comment 1 Andrew Johnson CLA 2011-07-05 08:53:55 EDT 
http://help.eclipse.org/indigo/index.jsp?topic=/org.eclipse.platform.doc.isv/reference/api/org/eclipse/ui/views/contentoutline/package-tree.html
says for IContentOutlinePage

Clients may implement this interface from scratch, or subclass the abstract base class ContentOutlinePage. 

so this might be okay.
Comment 2 Andrew Johnson CLA 2013-05-20 09:01:54 EDT 
See bug 382378 comment 4.

Eclipse 4.2.2 does not flag this as a warning:

public abstract class SnapshotOutlinePage extends Page implements IContentOutlinePage

though if the 'extends Page' is removed it does say:

SnapshotOutlinePage illegally implements IPage via IContentOutlinePage

I think the existing code is okay, and the current tooling does not flag a problem.