Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313089 - [Linker] Linker gets confused with actions
Summary: [Linker] Linker gets confused with actions
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: RC1   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 05:25 EDT by Jan Koehnlein CLA
Modified: 2017-09-19 16:27 EDT (History)
1 user (show)

See Also:
jan: helios+

Attachments
Patch for the Linker (282.66 KB, patch)
2010-05-17 07:45 EDT, Jan Koehnlein CLA 		jan: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Koehnlein CLA 2010-05-17 05:25:07 EDT 
When using the plain Linker, I get linking exceptions

Cannot find reference org.eclipse.xtext.impl.CrossReferenceImpl@7f867f7f
   (cardinality: null)

when actions are involved. Seems like the linker is trying to resolve a cross reference in the wrong context.
Comment 1 Jan Koehnlein CLA 2010-05-17 07:45:55 EDT 
Created attachment 168714 [details]
Patch for the Linker

Added a patch: 

org.eclipse.xtext.linking.impl.Linker.ensureLinked(EObject, IDiagnosticProducer, CompositeNode, Set<EReference>) did not stop ascending in the node model when the parent had another semantic model set. 

As the same condition was correct in the sibling class LazyLinker, I extracted the condition into a method of the superclass.

Test included.
Comment 2 Jan Koehnlein CLA 2010-05-17 07:54:16 EDT 
Renamed the method to shouldCheckParentNode, added JavaDocs and committed.
Comment 3 Karsten Thoms CLA 2017-09-19 16:27:46 EDT 
Closing bug which were set to RESOLVED before Eclipse Neon.0.