Description Dmitry Neverov 2010-05-17 04:44:37 EDT

Build Identifier: 

We should not check flushCounter.get() > 0 in catch block, because of such scenario:

StreamCopyThread                         |OtherThread
-----------------------------------------+-----------------------------------
                                         |invoke flush()
                                         |  flushCounter.incrementAndGet();
n = src.read(buf);//read smth            | 
if (flushCounter.get() > 0) continue;    |               
if (needFlush())                         |
  dst.flush(); //now flushCounter is 0   |
src.read(buf); //block on read           |
                                         |  interrupt();
//in catch:                              |
if (flushCounter.get() > 0) //false      |
throw wakey;                             |
//in finally:                            |
src.close();                             |
dst.close();                             |
                                         |//return from flush() and try to write smth to closed stream,
                                         |//get IOException("Pipe closed")

Since we use StreamCopyThrea.interrupt() for signaling it should make flush(), let's always ignore InterruptedExceptions. Patch to fix it is attached.



Reproducible: Always