Community
Participate
Working Groups
From the build log file: key only? or incorrect copyright? Count: 4 1. 2007 Oracle Corporation and others.All rights reserved. This program and the accompanying materialsare made available under the terms of the Eclipse Public License v1.0which accompanies this distribution, and is available athttp://www.eclipse.org/legal/epl-v10.html Contributors: Oracle Corporation - initial API and implementation org.eclipse.jst.jsf.apache.trinidad.tagsupport.feature.source.feature.group 2.2.100.v20100429-208Z7w312114252964 2. 2007 Oracle Corporation and others.All rights reserved. This program and the accompanying materialsare made available under the terms of the Eclipse Public License v1.0which accompanies this distribution, and is available athttp://www.eclipse.org/legal/epl-v10.html Contributors: Oracle Corporation - initial API and implementation org.eclipse.jst.jsf.apache.trinidad.tagsupport.feature.source.feature.jar 2.2.100.v20100429-208Z7w312114252964 3. 2007 Oracle Corporation and others.All rights reserved. This program and the accompanying materialsare made available under the terms of the Eclipse Public License v1.0which accompanies this distribution, and is available athttp://www.eclipse.org/legal/epl-v10.html Contributors: Oracle Corporation - initial API and implementation org.eclipse.jst.webpageeditor.feature.source.feature.group 2.3.0.v20100429-46-9oB5855H7H 4. 2007 Oracle Corporation and others.All rights reserved. This program and the accompanying materialsare made available under the terms of the Eclipse Public License v1.0which accompanies this distribution, and is available athttp://www.eclipse.org/legal/epl-v10.html Contributors: Oracle Corporation - initial API and implementation org.eclipse.jst.webpageeditor.feature.source.feature.jar 2.3.0.v20100429-46-9oB5855H7H
Created attachment 168671 [details] Fix copyright
I think the word 'Copyright' is missing because the line in the properties file doesn't have a '\n' at the end. Please review and confirm if this is correct.
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. Helios requirement to have proper copyright header for features * Is there a work-around? If so, why do you believe the work-around is insufficient? No reasonable workaround * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? To be verified on the build * Give a brief technical overview. Who has reviewed this fix? See description. * What is the risk associated with this fix? none
I think the issue is something else. Notice all the problem cases are for "source" features. Such as org.eclipse.jst.jsf.apache.trinidad.tagsupport.feature.source These are auto generated, but based on files given in sourceTemplateFeature, for example \org.eclipse.jst.jsf.apache.trinidad.tagsupport.feature\sourceTemplateFeature In that directory, you'll see a feature.properties file that is indeed missing the word "Copyright " at the beginning: # "copyright" property - text of the "Feature Update Copyright" copyright=\ 2007 Oracle Corporation and others.\ All rights reserved. This program and the accompanying materials\
Created attachment 168676 [details] Updated Fix for copyright errors
Th(In reply to comment #4) > I think the issue is something else. Notice all the problem cases are for > "source" features. Such as > org.eclipse.jst.jsf.apache.trinidad.tagsupport.feature.source > > These are auto generated, but based on files given in sourceTemplateFeature, > for example > > \org.eclipse.jst.jsf.apache.trinidad.tagsupport.feature\sourceTemplateFeature > > In that directory, you'll see a feature.properties file that is indeed missing > the word "Copyright " at the beginning: > > # "copyright" property - text of the "Feature Update Copyright" > copyright=\ > 2007 Oracle Corporation and others.\ > All rights reserved. This program and the accompanying materials\ Thanks, David. I have updated the patch with those changes.
Released to RC2
