Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 313012 - Array values are not shown
Summary: Array values are not shown
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Simon Kaegi CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-15 07:43 EDT by Michael Schneider CLA
Modified: 2010-12-17 09:18 EST (History)
2 users (show)

See Also:
deboer: pmc_approved+
Michael_Rennie: review+

Attachments
Screenshot of the issue (166.33 KB, image/png)
2010-05-15 07:43 EDT, Michael Schneider CLA 		no flags Details
proposed patch (1.48 KB, patch)
2010-05-17 10:00 EDT, Simon Kaegi CLA 		no flags Details | Diff
screen shot (29.36 KB, image/png)
2010-05-17 13:10 EDT, Michael Rennie CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Schneider CLA 2010-05-15 07:43:18 EDT 
Created attachment 168631 [details]
Screenshot of the issue

See attached screenshot

I would expect that I can see the array entries as properties.
Comment 1 Simon Kaegi CLA 2010-05-15 20:14:14 EDT 
This is a regression and a must fix for RC2.
Comment 2 Simon Kaegi CLA 2010-05-17 10:00:15 EDT 
Created attachment 168730 [details]
proposed patch

The change to add non-enumerated properties inadvertently removed any specialization of getIds done in both Arrays and Functions. We need to merge the two id sets to get all of the appropriate values.
Comment 3 Michael Rennie CLA 2010-05-17 13:08:23 EDT 
patch could be a bit speedier if we just copy the values in to the set ourselves instead of using Arrays.asList and creating a garbage ArrayList...
Comment 4 Michael Rennie CLA 2010-05-17 13:10:43 EDT 
Created attachment 168766 [details]
screen shot

I also found that the details for an array object are including values that are not actually part of the Array. The screenshot shows the length of the array is being included as a value in the array (according to the var view and the details anyways)
Comment 5 Simon Kaegi CLA 2010-05-17 14:17:30 EDT 
Bug 313011 fixes up the variables view, this bug just makes sure we have the appropriate properties in array objects.
Comment 6 Michael Rennie CLA 2010-05-17 16:19:41 EDT 
works as intended, Simon promised to fix the details pane to once again show the array values and not just 'Array' before he commits it.
Comment 7 Simon Kaegi CLA 2010-05-17 17:08:03 EDT 
Fixed in HEAD
Comment 8 Michael Rennie CLA 2010-05-18 13:21:47 EDT 
woops noticed I set a pmc_approved flag, fixing to set a review flag from me.