Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312977 - [ValueConverters] EFactory-based converters are only registerd for data-type rules
Summary: [ValueConverters] EFactory-based converters are only registerd for data-type ...
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: RC2   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-14 16:10 EDT by Sebastian Zarnekow CLA
Modified: 2017-09-19 16:28 EDT (History)
2 users (show)

See Also:
sebastian.zarnekow: helios+

Attachments
DefaultTerminalConverter + Test (945.98 KB, text/plain)
2010-05-25 07:43 EDT, Jan Koehnlein CLA 		jan: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2010-05-14 16:10:03 EDT 
We should register them for terminal rules, too.
Comment 1 Sebastian Zarnekow CLA 2010-05-14 16:11:30 EDT 
Terminal-rule based EFactory converters should inherit from AbstractLexerBasedConverter.
Comment 2 Jan Koehnlein CLA 2010-05-25 07:43:27 EDT 
Created attachment 169811 [details]
DefaultTerminalConverter + Test

Use default value converters for terminal rules, delegating to the EFactory of the return type. 

All tests are green. I am committing this change, so we can roll it back using this patch if it fails in an unpredictable way.
Comment 3 Jan Koehnlein CLA 2010-05-25 07:47:17 EDT 
Patch applied.
Comment 4 Karsten Thoms CLA 2017-09-19 16:28:51 EDT 
Closing bug which were set to RESOLVED before Eclipse Neon.0.