Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312927 - CTabItem role description not the same as TabItem
Summary: CTabItem role description not the same as TabItem
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.6 RC2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-14 11:27 EDT by Silenio Quarti CLA
Modified: 2010-05-20 16:00 EDT (History)
2 users (show)

See Also:
skovatch: review+
carolynmacleod4: review+

Attachments
possible fix (1.97 KB, patch)
2010-05-14 11:30 EDT, Silenio Quarti CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Silenio Quarti CLA 2010-05-14 11:27:41 EDT 
The role of a CTabItem is AXRadioButton., which is correct, but the description should be "tab" instead of "radio button".
Comment 1 Silenio Quarti CLA 2010-05-14 11:30:34 EDT 
Created attachment 168549 [details]
possible fix

This patch fixes it, but it uses undocumented strings.
Comment 2 Scott Kovatch CLA 2010-05-14 22:23:00 EDT 
(In reply to comment #1)

> This patch fixes it, but it uses undocumented strings.

This is fine. We already do something like this for text alignment.
Comment 3 Silenio Quarti CLA 2010-05-19 19:00:07 EDT 
We should fix this for RC2.
Comment 4 Scott Kovatch CLA 2010-05-19 19:05:54 EDT 
Verified with CustomControlExample. Looks fine.
Comment 5 Carolyn MacLeod CLA 2010-05-20 10:09:32 EDT 
+1.  Interestingly, on my Mac (10.5.8) VoiceOver has always called CTabItems "tab".   :)
So I couldn't understand why it was so important to make this change for RC2... but now that I have listened to SSQ's Mac, I understand.    :)

SSQ and I are guessing that older versions of VoiceOver must have followed this logic: "if the role is radio button and the parent is tab folder then call it a tab". However (we speculate) someone must have set the description, and then complained that VoiceOver wasn't reading their description. So their problem was fixed, and our CTabFolder was broken. (just a little bit of forensics there <grin>).
Comment 6 Silenio Quarti CLA 2010-05-20 10:17:39 EDT 
Fixed > 20100520