Community
Participate
Working Groups
<response_by> Keiko Terada at 2010.05.13.20.33.11 </response_by> NLS Build Label: 20100512-1300 Language: Japanese Must-Fix: No Problem description: There are some extra spaces in front of the second Regular expression checkbox. ---------------- Procedure Start Eclipse In Workspace Launcher panel, you should accept the default and click the checkbox so you won't be prompted every time you start Eclipse Click OK Double click on Welcome On the menu bar from the main Workbench panel, click File --> New -> Project -> Java Project Double click on Java Project Next to Project name type TVT Click on the Next button Click on the Libraries tab Upon validating the panel click on the Finish button Click Search > Search from the main menu. <response_by> rewagner at 2010.05.14.09.51.48 </response_by> This article was reassigned from Category:''TVT/Testing,Inbox''. <response_by> rewagner at 2010.05.14.09.52.52 </response_by> This is an alignment problem. I tried it in a few different languages and it seems like those two radio buttons are right aligned. They should be left aligned. Thanks, Ross
Created attachment 168546 [details] 02.000.110.gif
<cde:tctdetail> Testcase: 02.000.110 - BASE FILE MENU - TVT PROJECT - SEARCH Project: WSW36 Component: Xfer - Platform/Search Priority: 3 Subject: JPN: Extra spaces in front of the second Regular expression checkbox Article ID: 252 Originator: terak@jp.ibm.com </cde:tctdetail>
That's not a search page from the SDK. Could you please give us the English name of the tab, so that we can move the bug to the right component? Or even better: Press Alt+Shift+F1 to see the contributing class/plug-in of the page. (In reply to comment #0) > ---------------- > Procedure > > Start Eclipse > In Workspace Launcher panel, you should accept the default and click the > checkbox so you won't be prompted every time you start Eclipse > Click OK > Double click on Welcome > On the menu bar from the main Workbench panel, click File --> New -> Project -> > Java Project > Double click on Java Project > Next to Project name type TVT > Click on the Next button > Click on the Libraries tab > Upon validating the panel click on the Finish button I don't understand what these steps should have to do with the reported bug.
AFAIK the translations are provided by IBM and hence the bug is not with Eclipse.
<response_by> Keiko Terada at 2010.05.16.20.06.44 </response_by> The Search dialog is opened in Remote system explorer perspective. Please see the screenshot taken on 20100516-0300.
Created attachment 168659 [details] 252_02.000.110_20100516-0300.gif
Can the RSE team take a look at this to see if there is a layout problem near the checkbox?
<response_by> Manuel Ferro at 2010.05.18.09.33.11 </response_by> Same problem for PTG and we, testers and translator, don't have the capability to align that text. Regards, Ricardo
I took a look at the code, it seems this problem is related to the fix for bug 279307. For the regular expression button for file name, it was changed from GridData.HORIZONTAL_ALIGN_BEGINNING to GridData.HORIZONTAL_ALIGN_END. Is it intentional? This is the source code fragment for SystemSearchPage#createFileNameControl() //gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd = new GridData(GridData.HORIZONTAL_ALIGN_END); gd.horizontalSpan = 3; fileNameRegexButton.setLayoutData(gd); fileNameRegexButton.setSelection(initialFileNameRegex); fileNameHintLabel.setVisible(!fileNameRegexButton.getSelection());
There was a reason for changing HORIZONTAL_ALIGN_BEGINNING to HORIZONTAL_ALIGN_END. If I tried it using HORIZONTAL_ALIGN_BEGINNING, the "Regular Expression" checkbox will be added to the next line. It is a minor issue, we will look into how to fix it properly later.
Created attachment 169139 [details] screen capture for change to HORIZONTAL_ALIGN_BEGINNING
Created attachment 169264 [details] fix Xuan, the regex checkbox for search string lined up properly because there is a label in the first column. I created a dummy label before the regex checkbox for file name, then the regex checkbox is lined up properly. Since I don't have access to the RSE CVS repository, I cannot create a patch. Please review this fix. Hope that helps!
Created attachment 169265 [details] Layout in Japanese after fix
I made the code change according to Kit's suggestion, and it worked. Please see the attachment for the patch (with comparison info). I will commit the patch into CVS. Kit, could you please add the legal statement to the comment of this bug? Thanks.
Created attachment 169390 [details] patch for the fix
Kevin, could you please review this fix? Thanks.
Review +.
I, Kit Lo, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, IBM Corporation, to make this contribution under the EPL.
I committed the fix.
Thanks for the fix! I released it for I20100521-0702. We need to add an iplog+ on the contribution, to add it to our IP Log. Kit - in order to do this properly, could you please attach the fix as a patch? I assume you could just download and re-attach what Xuan attached yesterday. Sorry for this extra effort, but it's the only way I see the IP Log tooling work properly for this. Thanks!
Created attachment 169488 [details] patch Here is my patch.
Comment on attachment 169488 [details] patch Thanks!
<response_by> Manuel Ferro at 2010.05.21.10.58.06 </response_by> It's fine, for portuguese, in build 20100520-0200 Regards, Ricardo
<response_by> Keiko Terada at 2010.05.24.00.39.32 </response_by> Verified fix for JA in 20100522-1600, thanks.
