Community
Participate
Working Groups
I added the pref years ago as a quick solution to the unexpected appearance of memory space options in the Add Memory Monitor dialog. On revisiting this, I've determined there is no need for the checkbox, as CDI-GDB doesn't support memory spaces at all. Any other CDI client that does support memory spaces will automatically get the memory space options in the dialog. In addition to removing the checkbox, I'm making the GDB ICDITarget no longer implement ICDIMemorySpaceManagement as there's no point to it doing so.
Created attachment 168490 [details] Fix
Committed to HEAD
*** cdt cvs genie on behalf of jcortell *** Bug 312848: Remove CDI-GDB pref to enable distinct code and data spaces [*] Target.java 1.63 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Target.java?root=Tools_Project&r1=1.62&r2=1.63 [*] IMIConstants.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/src/org/eclipse/cdt/debug/mi/core/IMIConstants.java?root=Tools_Project&r1=1.8&r2=1.9 [*] MIPreferenceInitializer.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/src/org/eclipse/cdt/debug/mi/core/MIPreferenceInitializer.java?root=Tools_Project&r1=1.4&r2=1.5 [*] MIPreferencePage.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/internal/ui/preferences/MIPreferencePage.java?root=Tools_Project&r1=1.16&r2=1.17 [*] PreferenceMessages.properties 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.ui/src/org/eclipse/cdt/debug/mi/internal/ui/preferences/PreferenceMessages.properties?root=Tools_Project&r1=1.8&r2=1.9
*** cdt cvs genie on behalf of jcortell *** Bug 312848: Remove CDI-GDB pref to enable distinct code and data spaces. Also fixed warnings [*] Target.java 1.64 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Target.java?root=Tools_Project&r1=1.63&r2=1.64
