Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312830 - [Mozilla] XPCOM error when removing DOM listeners should not crash
Summary: [Mozilla] XPCOM error when removing DOM listeners should not crash
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 14:45 EDT by Grant Gayed CLA
Modified: 2010-06-25 16:06 EDT (History)
0 users

See Also:

Attachments
patch (940 bytes, patch)
2010-05-13 14:57 EDT, Grant Gayed CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2010-05-13 14:45:08 EDT 
When showing the Welcome page at startup, if a Mozilla-based Browser is successfully created but then fails on the subsequent setText() call the workbench is immediately brought down.  This disposes the Browser, which unhooks its DOM listeners.  However the setText() failure can leave the underlying browser in an inconsistent state, which causes the listener unhooking to fail also.

Currently when this happens an error is thrown for the listener unhooking failure, which covers up the original error.  This failure should not cause a crash, firstly because the original error should not be covered up (it's the one that matters), and secondly because failure to remove DOM listeners does not really matter (the Browser's future function should not be affected).
Comment 1 Grant Gayed CLA 2010-05-13 14:57:09 EDT 
Created attachment 168440 [details]
patch

It's the first call in unhookDOMListeners() that can fail in this scenario, so this is the only place that the patch changes.
Comment 2 Grant Gayed CLA 2010-06-25 16:06:36 EDT 
fixed > 20100625