Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 312781 - Edit repository query wizard dialog bugzilla does not resize correctly
Summary: Edit repository query wizard dialog bugzilla does not resize correctly
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.4   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 08:56 EDT by Wim Jongman CLA
Modified: 2010-05-18 03:19 EDT (History)
2 users (show)

See Also:

Attachments
Expected resize of tables here (34.63 KB, image/png)
2010-05-13 08:57 EDT, Wim Jongman CLA 		no flags Details
mylyn/context/zip (9.55 KB, application/octet-stream)
2010-05-14 18:18 EDT, Wim Jongman CLA 		no flags Details
mylyn/context/zip (1.80 KB, application/octet-stream)
2010-05-14 18:27 EDT, Wim Jongman CLA 		no flags Details
commited patch (5.93 KB, patch)
2010-05-17 14:49 EDT, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (3.92 KB, application/octet-stream)
2010-05-17 14:49 EDT, Frank Becker CLA 		no flags Details
Screenshot (96.71 KB, image/png)
2010-05-18 03:19 EDT, Wim Jongman CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2010-05-13 08:56:35 EDT 
Resizing the Edit Repository Query wizard dialog does not resize correctly. Mylyn version that was shipped with Helios M7 RCP developers package. 

build-id: I20100429-1549
Comment 1 Wim Jongman CLA 2010-05-13 08:57:10 EDT 
Created attachment 168375 [details]
Expected resize of tables here
Comment 2 Wim Jongman CLA 2010-05-14 18:18:17 EDT 
Created attachment 168620 [details]
mylyn/context/zip

It seems to be the dialog.close() on line 101. The dialog is closed already when cancel is pressed inside the dialog.
Comment 3 Wim Jongman CLA 2010-05-14 18:23:36 EDT 
Wait, ignore the last comment, that was for bug 312782.
Comment 4 Wim Jongman CLA 2010-05-14 18:27:10 EDT 
Created attachment 168622 [details]
mylyn/context/zip
Comment 5 Frank Becker CLA 2010-05-15 15:59:15 EDT 
(In reply to comment #0)
> Resizing the Edit Repository Query wizard dialog does not resize correctly.
> Mylyn version that was shipped with Helios M7 RCP developers package.
> 
> build-id: I20100429-1549

Please give me some more information.

How do you resize the Edit Repository Query wizard dialog?

Can you get the expected size by select "more option" twice.

I have create an patch for bug#305687 and want to fix this to.
Comment 6 Wim Jongman CLA 2010-05-16 15:45:31 EDT 
(In reply to comment #5)

resize by dragging the trim area. I would expect the product, component, etc. boxes to grow because they contain more data.

"More options" does layout the dialog but it is not what I expect.
Comment 7 Frank Becker CLA 2010-05-17 14:49:34 EDT 
Created attachment 168795 [details]
commited patch
Comment 8 Frank Becker CLA 2010-05-17 14:49:37 EDT 
Created attachment 168796 [details]
mylyn/context/zip
Comment 9 Frank Becker CLA 2010-05-17 14:52:44 EDT 
Rob,

can you please verify, because this is used in two places.

Please reopen this bug if there is something wrong.

I add an minsize to the Page!
Comment 10 Wim Jongman CLA 2010-05-18 03:14:38 EDT 
Looks a lot better thanks! If you really want to polish the ui here is some extra work:

The resizing is exactly wat is expected. However, when the more options is flipped, the whole thing gets resized again. That is annoying. I suggest to remember the height before the flip and set the height after the flip.
Secondly, the more options contains the same tables. I would expect that the top columns and the more options columns get the same resize priority. See screenshot.
Comment 11 Wim Jongman CLA 2010-05-18 03:19:06 EDT 
Created attachment 168864 [details]
Screenshot